WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145307
EWS provides misleading information for not applyable patches
https://bugs.webkit.org/show_bug.cgi?id=145307
Summary
EWS provides misleading information for not applyable patches
Csaba Osztrogonác
Reported
2015-05-22 04:54:32 PDT
style checker says the following: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. ---- and other bubbles are green, because they didn't apply anything for example:
https://bugs.webkit.org/show_bug.cgi?id=145247
https://bugs.webkit.org/show_bug.cgi?id=126433
https://bugs.webkit.org/show_bug.cgi?id=138332
https://bugs.webkit.org/show_bug.cgi?id=126022
https://bugs.webkit.org/show_bug.cgi?id=70610
Attachments
Patch
(1.19 KB, patch)
2015-06-01 05:40 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2015-05-22 07:58:09 PDT
That would be a very recent regression. What changed?
Alexey Proskuryakov
Comment 2
2015-05-22 12:22:16 PDT
This just worked correctly in <
https://webkit-queues.appspot.com/patch/253595
> - windows bubble is red.
Alexey Proskuryakov
Comment 3
2015-05-22 12:29:20 PDT
Style checker is clearly wrong, but how did you determine that other bubbles in <
https://bugs.webkit.org/show_bug.cgi?id=145247
> are green for a wrong reason?
Csaba Osztrogonác
Comment 4
2015-06-01 05:19:07 PDT
(In reply to
comment #3
)
> Style checker is clearly wrong, but how did you determine that other bubbles > in <
https://bugs.webkit.org/show_bug.cgi?id=145247
> are green for a wrong > reason?
The problem is that webkit-patch tries to apply the patch, but there is no appliable diff in the patch. In this case the green GTK/Mac/EFL bubbles mean that the trunk is buildable, nothing else. It is very misleading. I think the best fix would be to make svn-apply not to return 0 in this case.
Csaba Osztrogonác
Comment 5
2015-06-01 05:40:52 PDT
Created
attachment 253994
[details]
Patch
Alexey Proskuryakov
Comment 6
2015-06-01 09:27:23 PDT
To summarize, this happens when a patch tries to update non-existent files. When a patch doesn't apply to existent files, we already get the correct behavior. Given that, I suspect that a more targeted fix is possible. However, adding a catch-all like this is fine too.
WebKit Commit Bot
Comment 7
2015-06-01 10:13:49 PDT
Comment on
attachment 253994
[details]
Patch Clearing flags on attachment: 253994 Committed
r185062
: <
http://trac.webkit.org/changeset/185062
>
WebKit Commit Bot
Comment 8
2015-06-01 10:13:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug