Bug 145273 – AX: Figure out why list-detection2.html test fails on GTK

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

It looks like list-detection2.html fails on GTK
I'm adding a failure entry to TestExpectations, but someone should check this out and figure out what we need here to make it work

[Radar WebKit Bug Importer]

<rdar://problem/21059377>

[Joanmarie Diggs]

Probably due to AccessibilityUIElement::computedRoleString() not being implemented in ATK. I'll do that this evening or tomorrow.

[Joanmarie Diggs]

*** Bug 145255 has been marked as a duplicate of this bug. ***

[Joanmarie Diggs]

In addition to implementing computedRoleString() it looks like there's an issue with some pseudo elements:

FAIL: ul w/ bullet content on ::before -> group. Expected: list.
FAIL: ul w/ bullet content on inline ::before -> group. Expected: list.
FAIL: ol w/ counter content on ::before -> group. Expected: list.
FAIL: ol w/ counter content on inline ::before -> group. Expected: list.

[Joanmarie Diggs]

Ugh, there's additional problems with the heuristics. In the non-list cases, the list gets mapped to a more generic (but incorrect for my platform) role. They should be ATK_ROLE_SECTION; not ATK_ROLE_PANEL. But even worse, the list items still have role list item.

[Joanmarie Diggs]

Created attachment 253581 [details]
Patch

[Joanmarie Diggs]

(In reply to comment #5)
> Ugh, there's additional problems with the heuristics. In the non-list cases,
> the list gets mapped to a more generic (but incorrect for my platform) role.
> They should be ATK_ROLE_SECTION; not ATK_ROLE_PANEL. But even worse, the
> list items still have role list item.

Opened bug 145300 for the above.

[WebKit Commit Bot]

Comment on attachment 253581 [details]
Patch

Clearing flags on attachment: 253581

Committed r184765: <http://trac.webkit.org/changeset/184765>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This change made accessibility/list-detection2.html crash on Windows.

[Joanmarie Diggs]

(In reply to comment #10)
> This change made accessibility/list-detection2.html crash on Windows.

You have a backtrace? When I look at https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r184783%20(66325)/accessibility/list-detection2-crash-log.txt I see No crash log found for DumpRenderTree:3340.

[Joanmarie Diggs]

Reopening to deal with the crash on Win.

[Joanmarie Diggs]

Created attachment 253612 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 253612 [details]
Patch

Chris: Since your platform didn't need this check and since it crashes on Windows, I've added platform checks so I can fix the crash now. (It's Friday, holiday weekend, etc. ;))

Alexey: If you can get me a backtrace and open a new bug, I'll add it to my list of things to look into.

[WebKit Commit Bot]

Comment on attachment 253612 [details]
Patch

Clearing flags on attachment: 253612

Committed r184801: <http://trac.webkit.org/changeset/184801>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.