In file included from ../../Source/WebKit2/WebProcess/Plugins/PluginView.cpp:27:
../../Source/WebKit2/WebProcess/Plugins/PluginView.h:254:10: warning: private field 'm_didPlugInStartOffScreen' is not used [-Wunused-private-field]
../../Source/WebKit2/WebProcess/Plugins/PluginView.h:290:14: warning: private field 'm_countSnapshotRetries' is not used [-Wunused-private-field]
2 warnings generated.
- m_didPlugInStartOffScreen is only used inside ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC) guard
- m_countSnapshotRetries in only used once inside ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
and once inside PLATFORM(COCOA) guard
Created attachment 253514 [details]
OMG, ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC is defined
in Source/WebKit2/WebProcess/WebPage/WebPage.h. But why there? :-/
( This define was added in http://trac.webkit.org/changeset/145332 )
Created attachment 253518 [details]
(In reply to comment #3)
> Created attachment 253518 [details]
I moved the definition of ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC
from Source/WebKit2/WebProcess/WebPage/WebPage.h to FeatureDefines.h.
It is incorrect to define an ENABLE_* guard in any local header, the
value of all ENABLE guard must be same everywhere in the codebase. Now
it is true if you include WebPage.h and PLATFORM(COCOA) is true, but
it is false if you don't include WebPage.h.
Timothy, Dean, you owned r145332 which added this warning,
so please take a look at the proposed fix. Thanks.
Comment on attachment 253518 [details]
Clearing flags on attachment: 253518
Committed r185742: <http://trac.webkit.org/changeset/185742>
All reviewed patches have been landed. Closing bug.