WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111932
Add a heuristic to determine the “primary” snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111932
Summary
Add a heuristic to determine the “primary” snapshotted plugin
Tim Horton
Reported
2013-03-09 17:34:45 PST
So it could be styled differently, etc. via a UA stylesheet. <
rdar://problem/13270208
>
Attachments
patch
(13.14 KB, patch)
2013-03-09 18:09 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(13.14 KB, patch)
2013-03-09 18:12 PST
,
Tim Horton
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
patch
(12.88 KB, patch)
2013-03-09 18:21 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(17.47 KB, patch)
2013-03-09 19:37 PST
,
Tim Horton
dino
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-03-09 17:39:09 PST
Putting it in WK2 because that’ll keep it out of the way for most people... while a heuristic like this doesn’t really belong in WebKit at all - it’s going to require a good bit of effort to make it possible to put it in the client. We plan to eventually expose enough knowledge to do that, but not yet.
Tim Horton
Comment 2
2013-03-09 18:09:51 PST
Created
attachment 192362
[details]
patch
Tim Horton
Comment 3
2013-03-09 18:12:35 PST
Created
attachment 192363
[details]
patch
Early Warning System Bot
Comment 4
2013-03-09 18:18:34 PST
Comment on
attachment 192363
[details]
patch
Attachment 192363
[details]
did not pass qt-wk2-ews (qt): Output:
http://webkit-commit-queue.appspot.com/results/17009871
EFL EWS Bot
Comment 5
2013-03-09 18:19:12 PST
Comment on
attachment 192363
[details]
patch
Attachment 192363
[details]
did not pass efl-ews (efl): Output:
http://webkit-commit-queue.appspot.com/results/17122184
Tim Horton
Comment 6
2013-03-09 18:21:54 PST
Created
attachment 192364
[details]
patch
Sam Weinig
Comment 7
2013-03-09 19:13:40 PST
Can we use a different #define that PLATFORM(MAC) for this, at the very least to be more descriptive.
Tim Horton
Comment 8
2013-03-09 19:14:52 PST
(In reply to
comment #7
)
> Can we use a different #define that PLATFORM(MAC) for this, at the very least to be more descriptive.
Yeah, I was considering that. Currently trying to consolidate all of the #ifs in one file so that that becomes less touch-Platform.h and more add-something-to-the-top-of-WebPage.
Tim Horton
Comment 9
2013-03-09 19:25:36 PST
(In reply to
comment #8
)
> (In reply to
comment #7
) > > Can we use a different #define that PLATFORM(MAC) for this, at the very least to be more descriptive. > > Yeah, I was considering that. Currently trying to consolidate all of the #ifs in one file so that that becomes less touch-Platform.h and more add-something-to-the-top-of-WebPage.
I’m having a hard time telling if that’s a legitimate thing to do. People seem to be using WTF_USE_ for that, which I think is wrong, it should be WTF_ENABLE_, and it’s not done very often. I’ll move it to Platform.h/wherever if someone complains.
Tim Horton
Comment 10
2013-03-09 19:37:07 PST
Created
attachment 192367
[details]
patch
Dean Jackson
Comment 11
2013-03-10 13:36:32 PDT
Comment on
attachment 192367
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=192367&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3953 > + LayoutUnit contentArea = renderBox->contentWidth() * renderBox->contentHeight(); > + > + if (renderBox->contentWidth() < primarySnapshottedPlugInMinimumWidth || renderBox->contentHeight() < primarySnapshottedPlugInMinimumHeight) > + continue;
You can swap these two statements.
Tim Horton
Comment 12
2013-03-10 13:52:56 PDT
http://trac.webkit.org/changeset/145332
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug