WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
14525
Support exslt:node-set()
https://bugs.webkit.org/show_bug.cgi?id=14525
Summary
Support exslt:node-set()
Alexey Proskuryakov
Reported
2007-07-04 12:57:06 PDT
According to the discussion in
bug 4079
, the most important part of EXSLT to support is node-set().
Attachments
proposed patch
(14.79 KB, patch)
2007-07-04 13:16 PDT
,
Alexey Proskuryakov
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2007-07-04 13:16:12 PDT
Created
attachment 15389
[details]
proposed patch The copyright notice is taken from libexslt verbatim; it seems to be basically the same BSD-style licence AFAICT. I took the node-set() implementation from libexslt 1.1.11, as it's the version shipped with Mac OS X 10.4. Newer versions have some correctness fixes (that seem relatively minor), but don't build with the old libxslt.
M. David Peterson
Comment 2
2007-07-04 13:30:28 PDT
This is great to see! Thanks! :D
Maciej Stachowiak
Comment 3
2007-07-05 19:27:57 PDT
Comment on
attachment 15389
[details]
proposed patch This looks like a good move until we decide whether we want full exslt. r=me
Maciej Stachowiak
Comment 4
2007-07-05 19:28:28 PDT
This might be better for the feature branch, but also seems like a reasonable compatibility fix.
Alexey Proskuryakov
Comment 5
2007-07-06 01:24:52 PDT
Yes, I was looking at this as a compatibility fix, planning to land on trunk.
Alexey Proskuryakov
Comment 6
2007-07-07 03:03:34 PDT
Committed to trunk, revision 24088. See
bug 4079 comment 15
:-)
M. David Peterson
Comment 7
2007-07-07 09:23:16 PDT
(In reply to
comment #6
)
> Committed to trunk, revision 24088. > > See
bug 4079 comment 15
:-) >
YES! You are a *ROCKSTAR*, Alexey!!! :D Thank you! :D
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug