Bug 145119 - Fix uninitialized warnings in RealtimeMediaSourceCenterOwr.cpp
Summary: Fix uninitialized warnings in RealtimeMediaSourceCenterOwr.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121 142476
  Show dependency tree / graph
 
Reported: 2015-05-18 02:22 PDT by Csaba Osztrogonác
Modified: 2015-05-18 18:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.16 KB, patch)
2015-05-18 02:25 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (2.16 KB, patch)
2015-05-18 02:38 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-05-18 02:22:34 PDT 
./../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:94:9: warning: variable 'types' is uninitialized when used here [-Wuninitialized]
../../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:92:14: note: initialize the variable 'types' to silence this warning
../../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:157:18: warning: variable 'sourceType' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

( This file introduced in http://trac.webkit.org/changeset/181893 . )
Comment 1 Csaba Osztrogonác 2015-05-18 02:25:16 PDT 
Created attachment 253315 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-05-18 02:38:46 PDT 
Created attachment 253317 [details]
Patch
Comment 3 Gyuyoung Kim 2015-05-18 18:10:18 PDT 
Comment on attachment 253317 [details]
Patch

LGTM
Comment 4 WebKit Commit Bot 2015-05-18 18:39:35 PDT 
Comment on attachment 253317 [details]
Patch

Clearing flags on attachment: 253317

Committed r184537: <http://trac.webkit.org/changeset/184537>
Comment 5 WebKit Commit Bot 2015-05-18 18:39:40 PDT 
All reviewed patches have been landed.  Closing bug.