Bug 145056 – JS binding generator should create a member variable for each Promise attribute of an interface

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[youenn fablet]

As shown currently in ReadableStreamReader.idl, attributes may be Promise.
In that case, it would be nice for JS-generated classes to have a promise member so that it does not get stored in a different ways (by the implementation class or as show in JSReadableStreamReaderCustom as an internal slot).

This would be a first step towards promise attribute binding without custom getter.

[youenn fablet]

Created attachment 253201 [details]
Patch

[Darin Adler]

Comment on attachment 253201 [details]
Patch

Can we include a test of this on actual interfaces we implement, not just bindings regression tests?

[Darin Adler]

Oh, I see, the only one is new in ReadableStreamReader?

[youenn fablet]

(In reply to comment #3)
> Oh, I see, the only one is new in ReadableStreamReader?

Yes.

Once we have this patch landed, plan is to use that in ReadableStreamReader and remove the "internal slot" current "hack" and related routines.

We can also merge the two patches.

Once automated promise function binding generation is done, we might be able to tackle promise attribute binding generation if that is worth it

[WebKit Commit Bot]

Comment on attachment 253201 [details]
Patch

Clearing flags on attachment: 253201

Committed r184643: <http://trac.webkit.org/changeset/184643>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Plan is to revert these changes as a solution based on CachedAttribute seems more appropriate.
See https://bugs.webkit.org/show_bug.cgi?id=147828