We should revert http://trac.webkit.org/changeset/184643, https://bugs.webkit.org/show_bug.cgi?id=145056 now that we are using CachedAttribute instead.
Created attachment 258619 [details] Patch
Comment on attachment 258619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258619&action=review > Source/WebCore/ChangeLog:-25843 > 2015-05-20 Youenn Fablet <youenn.fablet@crf.canon.fr> > > - JS binding generator should create a member variable for each Promise attribute of an interface > - https://bugs.webkit.org/show_bug.cgi?id=145056 > - > - Reviewed by Darin Adler. > - > - For each attribute XXX whose type is Promise, a member m_XXXPromiseDeferred is created, its type being a JSC::Strong of JSPromiseDeferred. > - The purpose is to enable custom getters to create the JSPromiseDeferred and store ino the class member to ensure the same promise is returned each time > - the custom getter is called. > - This patch will enable simplifying ReadableStreamReader custom binding. > - > - Covered by added attribute in TestObj.idl. > - > - * bindings/scripts/CodeGeneratorJS.pm: > - (GenerateHeader): > - * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: > - (webkit_dom_test_obj_get_property): > - (webkit_dom_test_obj_class_init): > - (webkit_dom_test_obj_get_test_promise_attr): > - (webkit_dom_test_obj_set_nullable_string_value): Deleted. > - * bindings/scripts/test/GObject/WebKitDOMTestObj.h: > - * bindings/scripts/test/JS/JSTestObj.cpp: > - (WebCore::jsTestObjTestPromiseAttr): > - (WebCore::jsTestObjAttributeWithReservedEnumType): Deleted. > - * bindings/scripts/test/JS/JSTestObj.h: > - * bindings/scripts/test/ObjC/DOMTestObj.h: > - * bindings/scripts/test/ObjC/DOMTestObj.mm: > - (-[DOMTestObj testPromiseAttr]): > - (-[DOMTestObj attribute]): Deleted. > - * bindings/scripts/test/TestObj.idl: > - > -2015-05-20 Youenn Fablet <youenn.fablet@crf.canon.fr> > - Shouldn’t include this.
Created attachment 258819 [details] Patch for landing
Comment on attachment 258819 [details] Patch for landing Clearing flags on attachment: 258819 Committed r188334: <http://trac.webkit.org/changeset/188334>
All reviewed patches have been landed. Closing bug.