Bug 144981 – Use Ref instead of PassRefPtr in WebCore/bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

SSIA

[Gyuyoung Kim]

Created attachment 253080 [details]
Patch

[Darin Adler]

Comment on attachment 253080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253080&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2655
>                                                                  MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
>                                                                  SerializationErrorMode throwExceptions)

Not lined up any more. Better to put it all on one line,

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2670
>          return 0;

nullptr?

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2679
>          return 0;

nullptr?

> Source/WebCore/bindings/objc/ObjCEventListener.h:41
> +        static RefPtr<ObjCEventListener> wrap(ObjCListener);

Should return Ref, not RefPtr. If you look at the implementation you’ll see it never returns null.

> Source/WebCore/bindings/objc/ObjCEventListener.mm:55
>          return wrapper;

Need to use releaseNonNull here to convert the RefPtr into a Ref.

[Gyuyoung Kim]

Created attachment 253359 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #2)
> Comment on attachment 253080 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253080&action=review
> 
> > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2655
> >                                                                  MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
> >                                                                  SerializationErrorMode throwExceptions)
> 
> Not lined up any more. Better to put it all on one line,
> 
> > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2670
> >          return 0;
> 
> nullptr?
> 
> > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2679
> >          return 0;
> 
> nullptr?
> 
> > Source/WebCore/bindings/objc/ObjCEventListener.h:41
> > +        static RefPtr<ObjCEventListener> wrap(ObjCListener);
> 
> Should return Ref, not RefPtr. If you look at the implementation you’ll see
> it never returns null.
> 
> > Source/WebCore/bindings/objc/ObjCEventListener.mm:55
> >          return wrapper;
> 
> Need to use releaseNonNull here to convert the RefPtr into a Ref.

All done ! Thanks.

[WebKit Commit Bot]

Comment on attachment 253359 [details]
Patch for landing

Rejecting attachment 253359 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 253359, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6377800806170624

[Gyuyoung Kim]

Created attachment 253364 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 253364 [details]
Patch for landing

Clearing flags on attachment: 253364

Committed r184543: <http://trac.webkit.org/changeset/184543>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.