Bug 144906 – REGRESSION(r176631): [EFL] Fullscreen feature doesn't work correctly on MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

I don't know when this feature doesn't work correctly though, I'm sure we have to fix this problem ASAP.

Reproduce site : http://robnyman.github.io/fullscreen/

[Gyuyoung Kim]

Created attachment 252948 [details]
screenshot

[[e-mail]]

I've checked that this issue depends on 139109.
Without 139109 patch, Fullscreen feature doesn't work correctly on MiniBrowser.

[[e-mail]]

Sorry,
Without 139109 patch, Fullscreen feature works correctly on MiniBrowser.

[Gyuyoung Kim]

(In reply to comment #3)
> Sorry,
> Without 139109 patch, Fullscreen feature works correctly on MiniBrowser.

Oh, this bug is a regression caused by r176631. Thank you for finding it !.

Anyway, Daegyu, will you upload a patch to fix this issue ? If not, I will do.

[[e-mail]]

Created attachment 253021 [details]
patch

[Gyuyoung Kim]

Comment on attachment 253021 [details]
patch

IIRC, if m_hadUserInteraction is true, I made this function returns false as below,

bool PageViewportController::updateMinimumScaleToFit(bool userInitiatedUpdate)
{
    if (m_viewportSize.isEmpty() || m_contentsSize.isEmpty() || !m_initiallyFitToViewport || m_hadUserInteraction)
        return false;
  
In this case, however, applyScaleAfterRenderingContents() sometimes needs to be called when m_hadUserInteraction is false. Daegyu, did you run DISABLED_ewk_view_scale_with_fixed_layout() in test_ewk2_view.cpp ? I wonder this patch can fix the disabled API test as well. 

LGTM. r=me.

[[e-mail]]

I've checked the DISABLED_ewk_view_scale_with_fixed_layout() is failed with or without this patch.

[Gyuyoung Kim]

(In reply to comment #7)
> I've checked the DISABLED_ewk_view_scale_with_fixed_layout() is failed with
> or without this patch.

Thank you for the check.

[WebKit Commit Bot]

Comment on attachment 253021 [details]
patch

Clearing flags on attachment: 253021

Committed r184283: <http://trac.webkit.org/changeset/184283>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.