Bug 139109 - [EFL] ewk_view_scale_set() doesn't work correctly
Summary: [EFL] ewk_view_scale_set() doesn't work correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144906
  Show dependency treegraph
 
Reported: 2014-11-30 06:53 PST by Gyuyoung Kim
Modified: 2015-05-12 19:36 PDT (History)
3 users (show)

See Also:


Attachments
WIP (6.00 KB, patch)
2014-11-30 07:03 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.83 KB, patch)
2014-12-01 02:22 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2014-12-01 17:14 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.78 KB, patch)
2014-12-01 17:47 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-11-30 06:53:26 PST
When fixed layout is enabled on EFL port, it doesn't work correctly. 

 - WebPageProxy's m_pageScaleFactor is not synchronized with PageViewportController's one.
 - PageViewportController::syncVisibleContents() is failed to finish work though, its caller updates m_pageScaleFactor.
 - And so on.
Comment 1 Gyuyoung Kim 2014-11-30 07:03:48 PST
Created attachment 242290 [details]
WIP
Comment 2 Gyuyoung Kim 2014-12-01 02:22:32 PST
Created attachment 242306 [details]
Patch
Comment 3 Gyuyoung Kim 2014-12-01 02:36:30 PST
CC'ing Ossy.
Comment 4 Gyuyoung Kim 2014-12-01 17:07:10 PST
(In reply to comment #3)
> CC'ing Ossy.

Ossy, could you take a look ? This patch can fix scale and zooming on EFL MiniBrowser.
Comment 5 Gyuyoung Kim 2014-12-01 17:14:23 PST
Created attachment 242366 [details]
Patch
Comment 6 Gyuyoung Kim 2014-12-01 17:47:59 PST
Created attachment 242372 [details]
Patch
Comment 7 Csaba Osztrogonác 2014-12-02 01:57:12 PST
Comment on attachment 242372 [details]
Patch

rs=me
Comment 8 WebKit Commit Bot 2014-12-02 03:22:58 PST
Comment on attachment 242372 [details]
Patch

Clearing flags on attachment: 242372

Committed r176631: <http://trac.webkit.org/changeset/176631>
Comment 9 WebKit Commit Bot 2014-12-02 03:23:03 PST
All reviewed patches have been landed.  Closing bug.