Bug 144873 - Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate()
Summary: Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimension...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 142544
  Show dependency tree / graph
 
Reported: 2015-05-11 10:56 PDT by Chris Dumez
Modified: 2015-05-11 12:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2015-05-11 11:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-05-11 10:56:22 PDT 
Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate():
bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && !isVertical);
->
bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && isVertical);
Comment 1 Chris Dumez 2015-05-11 11:01:18 PDT 
Created attachment 252868 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-05-11 11:12:28 PDT 
Comment on attachment 252868 [details]
Patch

Did any test detect this?
Comment 3 Chris Dumez 2015-05-11 11:13:46 PDT 
(In reply to comment #2)
> Comment on attachment 252868 [details]
> Patch
> 
> Did any test detect this?

Not that I am aware of, it merely stood out when I was reviewing this code.
Comment 4 WebKit Commit Bot 2015-05-11 12:02:52 PDT 
Comment on attachment 252868 [details]
Patch

Clearing flags on attachment: 252868

Committed r184114: <http://trac.webkit.org/changeset/184114>
Comment 5 WebKit Commit Bot 2015-05-11 12:02:59 PDT 
All reviewed patches have been landed.  Closing bug.