Bug 142544 – Optimize offsetWidth and offsetHeight to not necessarily do a layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Optimize offsetWidth and offsetHeight to not necessarily do a layout.

[Dave Hyatt]

Created attachment 248358 [details]
Patch

[WebKit Commit Bot]

Attachment 248358 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1952:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/dom/Document.cpp:1952:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 248358 [details]
Patch

Attachment 248358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5783148558286848

New failing tests:
fast/images/repaint-subrect-grid.html

[Build Bot]

Created attachment 248368 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Dave Hyatt]

Created attachment 248370 [details]
Try this

[WebKit Commit Bot]

Attachment 248370 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1952:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/dom/Document.cpp:1952:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 248429 [details]
Patch

[WebKit Commit Bot]

Attachment 248429 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:1952:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/dom/Document.cpp:1952:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Landed in r181396.

[Radar WebKit Bug Importer]

<rdar://problem/20161403>

[Simon Fraser (smfr)]

rdar://problem/19534337

[Chris Dumez]

Comment on attachment 248429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248429&action=review

> Source/WebCore/dom/Document.cpp:1931
> +    bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && !isVertical);

Is this really correct? I would have expected the second check to use "&& isVectical" instead of "&& !isVectical".