Bug 144872 - Purge PassRefPtr in WebCore/rendering
Summary: Purge PassRefPtr in WebCore/rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-05-11 09:06 PDT by Gyuyoung Kim
Modified: 2015-05-11 19:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.81 KB, patch)
2015-05-11 09:07 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (18.48 KB, patch)
2015-05-11 16:29 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (18.42 KB, patch)
2015-05-11 17:22 PDT, Gyuyoung Kim 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-05-11 09:06:19 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-05-11 09:07:13 PDT 
Created attachment 252861 [details]
Patch
Comment 2 Gyuyoung Kim 2015-05-11 16:29:18 PDT 
Created attachment 252906 [details]
Patch
Comment 3 Gyuyoung Kim 2015-05-11 17:22:50 PDT 
Created attachment 252911 [details]
Patch
Comment 4 Darin Adler 2015-05-11 18:17:38 PDT 
Comment on attachment 252911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252911&action=review

> Source/WebCore/rendering/RenderThemeSafari.cpp:91
> +        return &windowsTheme; // keep the reference of one.

I don’t understand the comment “keep the reference of one”.

> Source/WebCore/rendering/RenderThemeSafari.cpp:93
> +    return &safariTheme; // keep the reference of one.

I don’t understand the comment “keep the reference of one”.
Comment 5 Gyuyoung Kim 2015-05-11 19:08:23 PDT 
Committed r184147: <http://trac.webkit.org/changeset/184147>
Comment 6 Gyuyoung Kim 2015-05-11 19:09:49 PDT 
(In reply to comment #4)

> I don’t understand the comment “keep the reference of one”.
> 
> > Source/WebCore/rendering/RenderThemeSafari.cpp:93
> > +    return &safariTheme; // keep the reference of one.
> 
> I don’t understand the comment “keep the reference of one”.

Landed after removing the unneeded comments.