Bug 144841 – Use Ref instead of PassRefPtr in WebCore/page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

To kill PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr in WebCore/page.

[Gyuyoung Kim]

Created attachment 252803 [details]
Patch

[Gyuyoung Kim]

Created attachment 252806 [details]
Patch

[Gyuyoung Kim]

Created attachment 252808 [details]
Patch

[Darin Adler]

Comment on attachment 252808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252808&action=review

OK to check in as long as you get iOS building.

> Source/WebCore/page/TextIndicator.h:86
>      WEBCORE_EXPORT static PassRefPtr<TextIndicator> createWithSelectionInFrame(Frame&, TextIndicatorPresentationTransition);
>      WEBCORE_EXPORT static PassRefPtr<TextIndicator> createWithRange(const Range&, TextIndicatorPresentationTransition);

Why did these two end up untouched?

> Source/WebCore/page/WebKitPoint.h:39
> +            return adoptRef(*new WebKitPoint());

I like to omit the optional () in cases like this.

> Source/WebCore/page/scrolling/ios/ScrollingTreeIOS.cpp:44
> -RefPtr<ScrollingTreeIOS> ScrollingTreeIOS::create(AsyncScrollingCoordinator* scrollingCoordinator)
> +Ref<ScrollingTreeIOS> ScrollingTreeIOS::create(AsyncScrollingCoordinator* scrollingCoordinator)

page/scrolling/ios/ScrollingTreeIOS.cpp:44:41: error: return type of out-of-line definition of 'WebCore::ScrollingTreeIOS::create' differs from that in the declaration

Need to modify the header too.

[Gyuyoung Kim]

Created attachment 252834 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #4)
> Comment on attachment 252808 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252808&action=review
> 
> OK to check in as long as you get iOS building.

Yes, fixed.

> > Source/WebCore/page/TextIndicator.h:86
> >      WEBCORE_EXPORT static PassRefPtr<TextIndicator> createWithSelectionInFrame(Frame&, TextIndicatorPresentationTransition);
> >      WEBCORE_EXPORT static PassRefPtr<TextIndicator> createWithRange(const Range&, TextIndicatorPresentationTransition);
> 
> Why did these two end up untouched?

Oh, I missed. Fixed too.
 
> > Source/WebCore/page/WebKitPoint.h:39
> > +            return adoptRef(*new WebKitPoint());
> 
> I like to omit the optional () in cases like this.
> 
> > Source/WebCore/page/scrolling/ios/ScrollingTreeIOS.cpp:44
> > -RefPtr<ScrollingTreeIOS> ScrollingTreeIOS::create(AsyncScrollingCoordinator* scrollingCoordinator)
> > +Ref<ScrollingTreeIOS> ScrollingTreeIOS::create(AsyncScrollingCoordinator* scrollingCoordinator)
> 
> page/scrolling/ios/ScrollingTreeIOS.cpp:44:41: error: return type of
> out-of-line definition of 'WebCore::ScrollingTreeIOS::create' differs from
> that in the declaration
> 
> Need to modify the header too.

ditto.

[Gyuyoung Kim]

Created attachment 252835 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 252835 [details]
Patch for landing

Clearing flags on attachment: 252835

Committed r184066: <http://trac.webkit.org/changeset/184066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.