Bug 144686 – Purge PassRefPtr in WebCore/html - 3

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

SSIA.

[Gyuyoung Kim]

Created attachment 252473 [details]
Patch

[Darin Adler]

Comment on attachment 252473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252473&action=review

> Source/WebCore/html/TimeRanges.cpp:35
> +Ref<TimeRanges> TimeRanges::create()

Oops, looks like this patch is missing TimeRanges.h.

> Source/WebCore/html/track/VTTRegionList.h:43
> +        return adoptRef(*new VTTRegionList());

I suggest we get rid of the unneeded () here.

[Gyuyoung Kim]

Created attachment 252550 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #2)
> Comment on attachment 252473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252473&action=review
> 
> > Source/WebCore/html/TimeRanges.cpp:35
> > +Ref<TimeRanges> TimeRanges::create()
> 
> Oops, looks like this patch is missing TimeRanges.h.
> 
> > Source/WebCore/html/track/VTTRegionList.h:43
> > +        return adoptRef(*new VTTRegionList());
> 
> I suggest we get rid of the unneeded () here.

All done.

[Gyuyoung Kim]

Created attachment 252571 [details]
Patch

[Gyuyoung Kim]

Created attachment 252579 [details]
Patch

[Gyuyoung Kim]

Created attachment 252587 [details]
Patch

[Andreas Kling]

Comment on attachment 252587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252587&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:55
> -    ASSERT_RANGE("{ }", TimeRanges::create());
> +    ASSERT_RANGE("{ }", TimeRanges::create().ptr());

This test is now asserting that a Ref is non-null, which is a bit funny, but fine.

> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:60
> -    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2));
> +    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());

Same here.

[Gyuyoung Kim]

Comment on attachment 252587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252587&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:55
>> +    ASSERT_RANGE("{ }", TimeRanges::create().ptr());
> 
> This test is now asserting that a Ref is non-null, which is a bit funny, but fine.

This seems to check if time range is correct, not nullptr or not. So it would be keep this for now.

>> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:60
>> +    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());
> 
> Same here.

ditto.

[WebKit Commit Bot]

Comment on attachment 252587 [details]
Patch

Clearing flags on attachment: 252587

Committed r183975: <http://trac.webkit.org/changeset/183975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.