Bug 144686 - Purge PassRefPtr in WebCore/html - 3
Summary: Purge PassRefPtr in WebCore/html - 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency treegraph
 
Reported: 2015-05-06 08:00 PDT by Gyuyoung Kim
Modified: 2015-05-07 19:20 PDT (History)
1 user (show)

See Also:


Attachments
Patch (26.89 KB, patch)
2015-05-06 08:01 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (28.88 KB, patch)
2015-05-06 18:29 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (29.54 KB, patch)
2015-05-06 22:48 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (30.24 KB, patch)
2015-05-07 01:25 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (30.24 KB, patch)
2015-05-07 05:33 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-05-06 08:00:27 PDT
SSIA.
Comment 1 Gyuyoung Kim 2015-05-06 08:01:17 PDT
Created attachment 252473 [details]
Patch
Comment 2 Darin Adler 2015-05-06 09:28:46 PDT
Comment on attachment 252473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252473&action=review

> Source/WebCore/html/TimeRanges.cpp:35
> +Ref<TimeRanges> TimeRanges::create()

Oops, looks like this patch is missing TimeRanges.h.

> Source/WebCore/html/track/VTTRegionList.h:43
> +        return adoptRef(*new VTTRegionList());

I suggest we get rid of the unneeded () here.
Comment 3 Gyuyoung Kim 2015-05-06 18:29:33 PDT
Created attachment 252550 [details]
Patch
Comment 4 Gyuyoung Kim 2015-05-06 18:29:53 PDT
(In reply to comment #2)
> Comment on attachment 252473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252473&action=review
> 
> > Source/WebCore/html/TimeRanges.cpp:35
> > +Ref<TimeRanges> TimeRanges::create()
> 
> Oops, looks like this patch is missing TimeRanges.h.
> 
> > Source/WebCore/html/track/VTTRegionList.h:43
> > +        return adoptRef(*new VTTRegionList());
> 
> I suggest we get rid of the unneeded () here.

All done.
Comment 5 Gyuyoung Kim 2015-05-06 22:48:56 PDT
Created attachment 252571 [details]
Patch
Comment 6 Gyuyoung Kim 2015-05-07 01:25:55 PDT
Created attachment 252579 [details]
Patch
Comment 7 Gyuyoung Kim 2015-05-07 05:33:41 PDT
Created attachment 252587 [details]
Patch
Comment 8 Andreas Kling 2015-05-07 09:11:16 PDT
Comment on attachment 252587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252587&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:55
> -    ASSERT_RANGE("{ }", TimeRanges::create());
> +    ASSERT_RANGE("{ }", TimeRanges::create().ptr());

This test is now asserting that a Ref is non-null, which is a bit funny, but fine.

> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:60
> -    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2));
> +    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());

Same here.
Comment 9 Gyuyoung Kim 2015-05-07 18:30:31 PDT
Comment on attachment 252587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252587&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:55
>> +    ASSERT_RANGE("{ }", TimeRanges::create().ptr());
> 
> This test is now asserting that a Ref is non-null, which is a bit funny, but fine.

This seems to check if time range is correct, not nullptr or not. So it would be keep this for now.

>> Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:60
>> +    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());
> 
> Same here.

ditto.
Comment 10 WebKit Commit Bot 2015-05-07 19:19:55 PDT
Comment on attachment 252587 [details]
Patch

Clearing flags on attachment: 252587

Committed r183975: <http://trac.webkit.org/changeset/183975>
Comment 11 WebKit Commit Bot 2015-05-07 19:20:00 PDT
All reviewed patches have been landed.  Closing bug.