Bug 144630 – Some assertion failures in compositing code after r183820

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

All that was changed was removal of a z-index: 0 from the media control styles.
This caused 5 tests to start generating assertion failures deep in compositing code, which implies an error with that code somehow.
After a bit of debugging I've decided that I have no idea where to even begin with compositing stuff.

The tests failing are:

compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/video-in-overflow-region.html
fast/regions/fullscreen/full-screen-video-from-region.html
fast/regions/fullscreen/full-screen-video-in-region-crash.html
fast/regions/inline-block-inside-anonymous-overflow.html

Though they pass in release.
In addition I have not hit the assertion just browsing around various videos using our controls in debug.
I will skip these tests for now.

[Radar WebKit Bug Importer]

<rdar://problem/20819825>

[Roger Fong]

Simon is taking a look at these.
Thanks Simon!

[Simon Fraser (smfr)]

    ASSERT(!layer.hasNotIsolatedCompositedBlendingDescendants() || layer.hasNotIsolatedBlendingDescendants());

[Simon Fraser (smfr)]

Seems related to isolates blending, and regions.

[Roger Fong]

Commented out assertion and unskipped tests here: http://trac.webkit.org/changeset/183843
Keeping bug open to keep track of the assertion being commented out.

[Simon Fraser (smfr)]

Created attachment 253871 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 253871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253871&action=review

rs=me

> Source/WebCore/ChangeLog:9
> +        escape the media elements, which was fixed in r145420.

This is probably bug 145420, not r145420.

[Simon Fraser (smfr)]

https://trac.webkit.org/r184992