Bug 144470 - Media control volume slider is opaque
Summary: Media control volume slider is opaque
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 144505
  Show dependency treegraph
Reported: 2015-04-30 14:35 PDT by Roger Fong
Modified: 2015-05-05 16:14 PDT (History)
4 users (show)

See Also:

patch (1.28 KB, patch)
2015-04-30 14:44 PDT, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-30 14:35:04 PDT
Comment 1 Roger Fong 2015-04-30 14:44:15 PDT
Created attachment 252091 [details]

Seeing as all the mix-blend-modes create new compositing regions on the controls anyways, the original z-index: 0 is now just hurting, not helping.

The fact that the volume slider blend doesn't work while all the other blends do probably has something to do with the fact that it's rotated off the main control bar.
Comment 2 Roger Fong 2015-05-01 13:13:21 PDT
Simon gave me the verbal go ahead over irc.
Comment 3 Alexey Proskuryakov 2015-05-01 15:32:53 PDT
It looks like this broke tests: <https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r183688%20(12422)/results.html>.

Roger is not on IRC, rolling out.
Comment 4 WebKit Commit Bot 2015-05-01 15:34:46 PDT
Re-opened since this is blocked by bug 144505
Comment 5 Roger Fong 2015-05-01 16:13:34 PDT
By removing a CSS property? That should never be the case. Sounds like a bug in the compositing code.
Comment 6 Alexey Proskuryakov 2015-05-03 19:57:29 PDT
The assertions went away after the rollout, so yes.
Comment 7 Roger Fong 2015-05-05 11:04:38 PDT
Re-landed with test expectations: http://trac.webkit.org/changeset/183820

Bug to track failures: https://bugs.webkit.org/show_bug.cgi?id=144630
Comment 8 Alexey Proskuryakov 2015-05-05 16:14:03 PDT
Is this really the right thing to do? We lose test coverage for all affected tests, not to mention that CrashReporter will make other tests more flaky.

Also, we still assert on fast/regions/inline-block-inside-anonymous-overflow.html and compositing/regions/transform-transparent-positioned-video-inside-region.html