In bug #143998 we removed ENABLE_LLINT_C_LOOP from the CMake build; now let's remove it completely.
Created attachment 251805 [details] Patch
Created attachment 251813 [details] Patch
Created attachment 251814 [details] Patch
There are CLOOP buildbots on https://build.webkit.org/waterfall which still use --cloop option, they should be changed to --no-jit. But in this case the buildmaster should be restarted immediately after the patch landed. - https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L233 - https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L491 Maybe it would be less intrusive if we keep --cloop option which could set ENABLE_JIT to 0.
OK, let's keep the --cloop argument to build-jsc then. I was hoping EWS would tell us if there is a problem with this patch, but I guess I'll need to keep an eye on that waterfall after landing.
Created attachment 251867 [details] Patch
Sounds like a good idea. Let's see if it builds.
It's fine by EWS at least. If I get r+ then I will check the waterfall after this lands and roll it out if the two cloop bots don't like it, but I bet it'll be fine.
Comment on attachment 251867 [details] Patch r=me
Comment on attachment 251867 [details] Patch Clearing flags on attachment: 251867 Committed r183514: <http://trac.webkit.org/changeset/183514>
All reviewed patches have been landed. Closing bug.
It broke the cloop bots: "Cannot build FTL JIT without baseline JIT support!" I will fix it. Ossy, thanks for mentioning that these exist, otherwise I would have had no clue.
Re-opened since this is blocked by bug 144359
Committed r183516: <http://trac.webkit.org/changeset/183516>
(In reply to comment #14) > Committed r183516: <http://trac.webkit.org/changeset/183516> This broke the --cloop feature. The CLoop bot has not been building the CLoop ever since. Will fix in https://bugs.webkit.org/show_bug.cgi?id=145516.
Oops, I was checking the cloop bots, but I guess "cloop bots are green and happy" is different from "cloop bots are actually testing cloop." :( Thanks for fixing.