Bug 143949 - Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories
Summary: Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the edit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2015-04-20 09:11 PDT by Darin Adler
Modified: 2015-04-22 22:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (48.70 KB, patch)
2015-04-20 09:39 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (49.09 KB, patch)
2015-04-20 10:10 PDT, Darin Adler 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (963.46 KB, application/zip)
2015-04-20 11:20 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (944.66 KB, application/zip)
2015-04-20 11:58 PDT, Build Bot 		no flags Details
Patch (50.42 KB, patch)
2015-04-22 19:41 PDT, Darin Adler 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-04-20 09:11:38 PDT 
Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories
Comment 1 Darin Adler 2015-04-20 09:39:46 PDT 
Created attachment 251161 [details]
Patch
Comment 2 Darin Adler 2015-04-20 10:10:45 PDT 
Created attachment 251164 [details]
Patch
Comment 3 Build Bot 2015-04-20 11:20:31 PDT 
Comment on attachment 251164 [details]
Patch

Attachment 251164 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4713467760082944

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2015-04-20 11:20:34 PDT 
Created attachment 251169 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-04-20 11:58:46 PDT 
Comment on attachment 251164 [details]
Patch

Attachment 251164 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4815801999687680

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2015-04-20 11:58:49 PDT 
Created attachment 251180 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Darin Adler 2015-04-22 19:41:14 PDT 
Created attachment 251398 [details]
Patch
Comment 8 Darin Adler 2015-04-22 19:41:59 PDT 
The new patch includes fixes for the test failures.
Comment 9 Andreas Kling 2015-04-22 21:19:47 PDT 
Comment on attachment 251398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251398&action=review

r=me

> Source/WebCore/platform/graphics/FontCascade.cpp:438
> +std::unique_ptr<TextLayout, void (*)(TextLayout*)> FontCascade::createLayout(RenderText&, float, bool) const
>  {
> +    return std::unique_ptr<TextLayout, void (*)(TextLayout*)>(nullptr, [](TextLayout*) { });
>  }

Oh wow, you were not kidding about this monstrosity.
Comment 10 Darin Adler 2015-04-22 22:09:06 PDT 
(In reply to comment #9)
> Oh wow, you were not kidding about this monstrosity.

I found a better way to write this after thinking about some suggestions from Anders. I’ll land it after I double check it compiles.
Comment 11 Darin Adler 2015-04-22 22:21:31 PDT 
Committed r183169: <http://trac.webkit.org/changeset/183169>