Bug 143949 – Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Darin Adler]

Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories

[Darin Adler]

Created attachment 251161 [details]
Patch

[Darin Adler]

Created attachment 251164 [details]
Patch

[Build Bot]

Comment on attachment 251164 [details]
Patch

Attachment 251164 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4713467760082944

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 251169 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 251164 [details]
Patch

Attachment 251164 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4815801999687680

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 251180 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Darin Adler]

Created attachment 251398 [details]
Patch

[Darin Adler]

The new patch includes fixes for the test failures.

[Andreas Kling]

Comment on attachment 251398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251398&action=review

r=me

> Source/WebCore/platform/graphics/FontCascade.cpp:438
> +std::unique_ptr<TextLayout, void (*)(TextLayout*)> FontCascade::createLayout(RenderText&, float, bool) const
>  {
> +    return std::unique_ptr<TextLayout, void (*)(TextLayout*)>(nullptr, [](TextLayout*) { });
>  }

Oh wow, you were not kidding about this monstrosity.

[Darin Adler]

(In reply to comment #9)
> Oh wow, you were not kidding about this monstrosity.

I found a better way to write this after thinking about some suggestions from Anders. I’ll land it after I double check it compiles.

[Darin Adler]

Committed r183169: <http://trac.webkit.org/changeset/183169>