Bug 143943 - Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
Summary: Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2015-04-19 22:52 PDT by Darin Adler
Modified: 2015-04-22 23:03 PDT (History)
0 users

See Also:

Attachments
Patch (29.28 KB, patch)
2015-04-19 23:03 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (29.28 KB, patch)
2015-04-19 23:27 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2015-04-20 09:45 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (29.99 KB, patch)
2015-04-21 08:55 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (29.99 KB, patch)
2015-04-21 08:56 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
Patch (35.58 KB, patch)
2015-04-22 21:38 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (35.67 KB, patch)
2015-04-22 22:23 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (35.53 KB, patch)
2015-04-22 22:34 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-04-19 22:52:23 PDT 
Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
Comment 1 Darin Adler 2015-04-19 23:03:18 PDT 
Created attachment 251144 [details]
Patch
Comment 2 Darin Adler 2015-04-19 23:27:05 PDT 
Created attachment 251146 [details]
Patch
Comment 3 Darin Adler 2015-04-20 09:45:45 PDT 
Created attachment 251162 [details]
Patch
Comment 4 Darin Adler 2015-04-20 10:14:13 PDT 
Comment on attachment 251162 [details]
Patch

Need to fix iOS compilation.
Comment 5 Darin Adler 2015-04-21 08:55:38 PDT 
Created attachment 251230 [details]
Patch
Comment 6 Darin Adler 2015-04-21 08:56:14 PDT 
Created attachment 251231 [details]
Patch
Comment 7 Anders Carlsson 2015-04-22 08:40:31 PDT 
Comment on attachment 251231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251231&action=review

iOS build needs fixing, Editor::insertDictationPhrases needs to be updated.

> Source/WebCore/platform/network/ios/QuickLook.mm:191
> +NSURLRequest *WebCore::registerQLPreviewConverterIfNeeded(NSURL *url, NSString *mimeType, NSData *data)

I think this should return a RetainPtr instead.
Comment 8 Darin Adler 2015-04-22 09:04:42 PDT 
Comment on attachment 251231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251231&action=review

>> Source/WebCore/platform/network/ios/QuickLook.mm:191
>> +NSURLRequest *WebCore::registerQLPreviewConverterIfNeeded(NSURL *url, NSString *mimeType, NSData *data)
> 
> I think this should return a RetainPtr instead.

I see your point. I thought it would just return an autoreleased object, but I guess there’s no guarantee that the result of [converter previewRequest] will still be valid once converter is released.
Comment 9 Darin Adler 2015-04-22 21:38:09 PDT 
Created attachment 251403 [details]
Patch
Comment 10 Darin Adler 2015-04-22 22:23:11 PDT 
Created attachment 251407 [details]
Patch
Comment 11 Darin Adler 2015-04-22 22:34:44 PDT 
Created attachment 251408 [details]
Patch
Comment 12 Darin Adler 2015-04-22 23:03:22 PDT 
Committed r183172: <http://trac.webkit.org/changeset/183172>