RESOLVED FIXED 143941
Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=143941
Summary Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
Darin Adler
Reported 2015-04-19 22:08:47 PDT
Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
Attachments
Patch (27.75 KB, patch)
2015-04-19 22:15 PDT, Darin Adler
gyuyoung.kim: review+
Darin Adler
Comment 1 2015-04-19 22:15:45 PDT
Darin Adler
Comment 2 2015-04-19 22:16:21 PDT
I looked and found we were almost done!
Darin Adler
Comment 3 2015-04-19 22:17:59 PDT
*** Bug 139018 has been marked as a duplicate of this bug. ***
Gyuyoung Kim
Comment 4 2015-04-19 22:54:59 PDT
Comment on attachment 251141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251141&action=review LGTM. > Source/JavaScriptCore/API/ObjCCallbackFunction.mm:406 > + m_instanceClass = nil; nullptr ?
Darin Adler
Comment 5 2015-04-19 23:05:29 PDT
(In reply to comment #4) > > Source/JavaScriptCore/API/ObjCCallbackFunction.mm:406 > > + m_instanceClass = nil; > > nullptr ? No, I think nil is right for this. Class is a pointer to an Objective-C object, although its type name does not look like the others, such as NSObject *.
Darin Adler
Comment 6 2015-04-19 23:06:37 PDT
Note You need to log in before you can comment on or make changes to this bug.