Bug 143941 - Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
Summary: Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
: 139018 (view as bug list)
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2015-04-19 22:08 PDT by Darin Adler
Modified: 2015-04-19 23:06 PDT (History)
1 user (show)

See Also:

Attachments
Patch (27.75 KB, patch)
2015-04-19 22:15 PDT, Darin Adler 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-04-19 22:08:47 PDT 
Remove all the remaining uses of OwnPtr and PassOwnPtr in JavaScriptCore
Comment 1 Darin Adler 2015-04-19 22:15:45 PDT 
Created attachment 251141 [details]
Patch
Comment 2 Darin Adler 2015-04-19 22:16:21 PDT 
I looked and found we were almost done!
Comment 3 Darin Adler 2015-04-19 22:17:59 PDT 
*** Bug 139018 has been marked as a duplicate of this bug. ***
Comment 4 Gyuyoung Kim 2015-04-19 22:54:59 PDT 
Comment on attachment 251141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251141&action=review

LGTM.

> Source/JavaScriptCore/API/ObjCCallbackFunction.mm:406
> +        m_instanceClass = nil;

nullptr ?
Comment 5 Darin Adler 2015-04-19 23:05:29 PDT 
(In reply to comment #4)
> > Source/JavaScriptCore/API/ObjCCallbackFunction.mm:406
> > +        m_instanceClass = nil;
> 
> nullptr ?

No, I think nil is right for this. Class is a pointer to an Objective-C object, although its type name does not look like the others, such as NSObject *.
Comment 6 Darin Adler 2015-04-19 23:06:37 PDT 
Committed r183005: <http://trac.webkit.org/changeset/183005>