Bug 143884 – Prefix isnan() with std

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Milan Crha]

Similar to bug #137966, the msys/mingw requires isnan() to be prefixed with std namespace, otherwise the build breaks.

[Milan Crha]

Created attachment 251030 [details]
proposed wk patch

Simply do it.

[Chris Dumez]

Fails to build on Mac:
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:471:72: error: expected unqualified-id
        return (m_entry.doubleVal == other.m_entry.doubleVal) || (std::isnan(m_entry.doubleVal) && std::isnan(other.m_entry.doubleVal));
                                                                       ^
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:1:
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/JavaScriptCorePrefix.h:10:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/math.h:179:7: note: expanded from macro 'isnan'
    ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
      ^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:471:105: error: expected unqualified-id
        return (m_entry.doubleVal == other.m_entry.doubleVal) || (std::isnan(m_entry.doubleVal) && std::isnan(other.m_entry.doubleVal));
                                                                                                        ^
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:1:
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/JavaScriptCorePrefix.h:10:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/math.h:179:7: note: expanded from macro 'isnan'
    ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
      ^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:471:105: error: expected expression
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/Options.cpp:1:
In file included from /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/JavaScriptCorePrefix.h:10:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/math.h:181:70: note: expanded from macro 'isnan'
                                  : __inline_isnanl((long double)(x)))
                                                                     ^
3 errors generated.

[Chris Dumez]

Comment on attachment 251030 [details]
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251030&action=review

> Source/JavaScriptCore/runtime/Options.cpp:471
> +        return (m_entry.doubleVal == other.m_entry.doubleVal) || (std::isnan(m_entry.doubleVal) && std::isnan(other.m_entry.doubleVal));

I think the problem is that this file includes math.h instead of cmath

[Chris Dumez]

Comment on attachment 251030 [details]
proposed wk patch

r=me with the header include fixed.

[Milan Crha]

(In reply to comment #3)
> I think the problem is that this file includes math.h instead of cmath

It might not be it, the Stopwatch.h includes cmath, but fails anyway.

[Joseph Pecoraro]

Looks like someone else fixed these in:
https://trac.webkit.org/changeset/187019

Marking bug as resolved.