Bug 143670 - [EFL] fix efreet error
Summary: [EFL] fix efreet error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 09:48 PDT by KwangHyuk
Modified: 2015-05-20 19:33 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.29 KB, patch)
2015-04-13 09:56 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2015-05-18 10:54 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2015-04-13 09:48:21 PDT
ERR<25282>:efreet_cache lib/efreet/efreet_cache.c:1134 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files
Comment 1 KwangHyuk 2015-04-13 09:56:09 PDT
Created attachment 250646 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-04-13 13:15:34 PDT
Is this bug same as bug134023? It would be good to fix it once. 
This undocumented "feature" is so annoying that the user have 
to add symlinks as root user manually to have a working EFL WebKit. :-/

I tried to get answer for this bug, bug noone answered ever. :(
Comment 3 Csaba Osztrogonác 2015-04-13 13:18:30 PDT
So could you describe me what is this efreet_cache_update magic variable?
And why do we need magic symlinks if it isn't set and why don't we need
if it is set. This changelog doesn't say anything about why is this fix good.
Comment 4 KwangHyuk 2015-04-13 21:57:57 PDT
(In reply to comment #3)
> So could you describe me what is this efreet_cache_update magic variable?
> And why do we need magic symlinks if it isn't set and why don't we need
> if it is set. This changelog doesn't say anything about why is this fix good.

It will not monitor icon and desktop cache basically.
however, in the webkit there is no listener for those caches AFAIK.
Comment 5 KwangHyuk 2015-05-18 10:54:16 PDT
Created attachment 253331 [details]
Patch
Comment 6 Ryuan Choi 2015-05-18 17:40:31 PDT
Comment on attachment 253331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253331&action=review

> Tools/ChangeLog:10
> +        Fix efreet error by using external variable efreet_cache_update.
> +        As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
> +        efreet error for efreet_cache does not occur.

Although I am not familiar with efreet_cache_update, 
I think that it looks workaround not to monitor efreet because elm_file_chooser uses efreet for the icon.
(MiniBrowser uses elm_file_chooser to download and open dialog for input[type=file])

Could you check whether these usages are fine with your patch?
Comment 7 KwangHyuk 2015-05-20 07:38:19 PDT
(In reply to comment #6)
> Comment on attachment 253331 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253331&action=review
> 
> > Tools/ChangeLog:10
> > +        Fix efreet error by using external variable efreet_cache_update.
> > +        As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
> > +        efreet error for efreet_cache does not occur.
> 
> Although I am not familiar with efreet_cache_update, 
> I think that it looks workaround not to monitor efreet because
> elm_file_chooser uses efreet for the icon.
> (MiniBrowser uses elm_file_chooser to download and open dialog for
> input[type=file])
> 
> Could you check whether these usages are fine with your patch?

I checked that file chooser is working without any issue or error messages. :)
Comment 8 Gyuyoung Kim 2015-05-20 18:36:01 PDT
Comment on attachment 253331 [details]
Patch

I don't know why EFL application should set "efree_cache_update" though, I feel I need to do rubber stamp. rs=me.
Comment 9 WebKit Commit Bot 2015-05-20 19:33:24 PDT
Comment on attachment 253331 [details]
Patch

Clearing flags on attachment: 253331

Committed r184691: <http://trac.webkit.org/changeset/184691>
Comment 10 WebKit Commit Bot 2015-05-20 19:33:29 PDT
All reviewed patches have been landed.  Closing bug.