Bug 134023 - [EFL] Performance tests, layouttests, MiniBrowser do not work since r169785
Summary: [EFL] Performance tests, layouttests, MiniBrowser do not work since r169785
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-18 02:20 PDT by Martin Hodovan
Modified: 2017-03-11 10:34 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Hodovan 2014-06-18 02:20:00 PDT
After updating EFL libraries from 1.7 to 1.9 (https://bugs.webkit.org/show_bug.cgi?id=125479) performance tests fail
with the following error message:

ERR<16816>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown
The name org.enlightenment.Efreet was not provided by any .service files
Comment 1 Csaba Osztrogonác 2014-06-20 01:48:49 PDT
I got the same error when I tried to run layout tests or MiniBrowser.
Could you guys share the magic you did on the perf bot with us?
Comment 2 Csaba Osztrogonác 2014-06-23 06:00:02 PDT
ping
Comment 3 Martin Hodovan 2014-06-23 07:32:14 PDT
(In reply to comment #1)
> I got the same error when I tried to run layout tests or MiniBrowser.
> Could you guys share the magic you did on the perf bot with us?

We noticed an alert in the build log of the EFL ARM bot that says:

    Your installation prefix is *NOT* /usr so this means you need
    to ensure some files are visible to dbus otherwise services cannot
    be started when needed. You will need to do the following:

    ln -s .../WebKitBuild/Dependencies/Root/share/dbus-1/services/org.enlightenment.Ethumb.service /usr/share/dbus-1/services/org.enlightenment.Ethumb.service
    ln -s .../WebKitBuild/Dependencies/Root/share/dbus-1/services/org.enlightenment.Efreet.service /usr/share/dbus-1/services/org.enlightenment.Efreet.service

    or add ".../WebKitBuild/Dependencies/Root/share" to $XDG_DATA_DIRS

Setting the XDG_DATA_DIRS environment variable only did not solve the problem, we had to create these two symlinks as well.
Still, we are looking for a better fix, that makes perf tests work 'out of the box', so the user won't have to use symlinks.
Comment 4 Csaba Osztrogonác 2014-11-19 01:56:03 PST
note: these symlinks should be updated after https://trac.webkit.org/changeset/175555 .

Just out of curiosity, isn't there a simpler way than this ugly hack?
If the directory structure changes or I would like to build WebKit
in a different directory, it will cause problems again and again.
Comment 5 Csaba Osztrogonác 2014-11-26 02:33:09 PST
ping? 

Any idea how to make EFL WebKit work out of the box without hacking 
the system with these symlinks or installing EFL to system path?
Comment 6 Csaba Osztrogonác 2014-11-26 04:00:49 PST
The alert isn't shown during building EFL anymore, only the warning 
to set $XDG_DATA_DIRS properly. It is already set properly by jhbuild.

But without the ugly and unacceptable hack (adding symlinks to /usr/share/),
performance tests still fail with the original error message.

Is there any plan to fix EFL to make it work out of the box?
Comment 7 Csaba Osztrogonác 2014-12-01 05:31:32 PST
ping?
Comment 8 Michael Catanzaro 2017-03-11 10:34:59 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.