Bug 143535 - JSArray::sortNumeric should handle ArrayWithUndecided
Summary: JSArray::sortNumeric should handle ArrayWithUndecided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 143582
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-08 14:02 PDT by Filip Pizlo
Modified: 2015-04-09 15:06 PDT (History)
13 users (show)

See Also:


Attachments
the patch (7.87 KB, patch)
2015-04-08 14:03 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-08 14:02:31 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-04-08 14:03:59 PDT
Created attachment 250382 [details]
the patch
Comment 2 Geoffrey Garen 2015-04-08 14:08:05 PDT
Comment on attachment 250382 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-04-08 14:15:24 PDT
Landed in http://trac.webkit.org/changeset/182567
Comment 4 Brent Fulgham 2015-04-09 08:42:06 PDT
This change introduced two Windows failures:

** The following JSC stress test failures have been introduced:
	regress/script-tests/sorting-benchmark.js.dfg-eager
	regress/script-tests/sorting-benchmark.js.dfg-eager-no-cjit-validate

Can you please resolve?
Comment 5 Csaba Osztrogonác 2015-04-09 09:59:37 PDT
(In reply to comment #4)
> This change introduced two Windows failures:
> 
> ** The following JSC stress test failures have been introduced:
> 	regress/script-tests/sorting-benchmark.js.dfg-eager
> 	regress/script-tests/sorting-benchmark.js.dfg-eager-no-cjit-validate
> 
> Can you please resolve?

These tests assert on the Apple Mac 32 bit debug bots too.
Comment 6 Csaba Osztrogonác 2015-04-09 10:00:34 PDT
regress/script-tests/sorting-benchmark.js.ftl-eager-no-cjit: ASSERTION FAILED: (spillFormat & DataFormatJS) || spillFormat == DataFormatInt32
regress/script-tests/sorting-benchmark.js.ftl-eager-no-cjit: /Volumes/Data/slave/mavericks-32bitJSC-debug/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp(871) : GPRReg JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal(JSC::DFG::Edge, JSC::DataFormat &) [strict = false]
Comment 7 Michael Saboff 2015-04-09 10:12:31 PDT
(In reply to comment #6)
> regress/script-tests/sorting-benchmark.js.ftl-eager-no-cjit: ASSERTION
> FAILED: (spillFormat & DataFormatJS) || spillFormat == DataFormatInt32
> regress/script-tests/sorting-benchmark.js.ftl-eager-no-cjit:
> /Volumes/Data/slave/mavericks-32bitJSC-debug/build/Source/JavaScriptCore/dfg/
> DFGSpeculativeJIT32_64.cpp(871) : GPRReg
> JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal(JSC::DFG::Edge,
> JSC::DataFormat &) [strict = false]

Looking into these failures.