Bug 143451 – [WK2][iOS] Regression(r182323): ASSERTION FAILED: WebCore::SQLiteDatabaseTracker::hasTransactionInProgress() in NetworkCache::Statistics::initialize()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We sometimes hit the following assertion:
ASSERTION FAILED: WebCore::SQLiteDatabaseTracker::hasTransactionInProgress() in NetworkCache::Statistics::initialize()

0x107ff3020 WTFCrash
0x1036fe3fc WebKit::NetworkCache::executeSQLCommand(WebCore::SQLiteDatabase&, WTF::String const&)
0x1036fdaaa WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0::operator()() const
0x1036fd6bc std::__1::__function::__func<WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0, std::__1::allocator<WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0>, void ()>::operator()()
0x107b4358a std::__1::function<void ()>::operator()() const
0x108014bb9 invocation function for block in WTF::WorkQueue::dispatch(std::__1::function<void ()>)
0x101beebfd _dispatch_call_block_and_release
0x101c0e40d _dispatch_client_callout
0x101bf50ff _dispatch_queue_drain
0x101bf46fc _dispatch_queue_invoke
0x101bf6c1f _dispatch_root_queue_drain
0x101bf66bc _dispatch_worker_thread3
0x101f308a6 _pthread_wqthread
0x101f2e0c5 start_wqthread

I do have a "WebCore::SQLiteTransactionInProgressAutoCounter transactionCounter" in NetworkCache::Statistics::initialize(). My current guess is that the SQLiteDatabaseTrackerClient can get set after transactionCounter is initialized but before executeSQLCommand() is called.

[Chris Dumez]

I can reproduce. Working on a fix now.

[Radar WebKit Bug Importer]

<rdar://problem/20437994>

[Chris Dumez]

Created attachment 250223 [details]
Patch

[Chris Dumez]

Comment on attachment 250223 [details]
Patch

Clearing flags on attachment: 250223

Committed r182437: <http://trac.webkit.org/changeset/182437>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.