Bug 143278 – [WK2][iOS] We should prevent NetworkProcess suspension while it has pending SQL transactions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We should prevent NetworkProcess suspension while it has pending SQL transactions, similarly to what we already do for WebProcesses.

Radar: <rdar://problem/20180799>

[Chris Dumez]

Created attachment 249861 [details]
Patch

[WebKit Commit Bot]

Attachment 249861 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:48:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 250009 [details]
Patch

[Chris Dumez]

No longer using Supplements, as per Anders' feedback via IRC.

[WebKit Commit Bot]

Attachment 250009 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 250009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250009&action=review

Do you really need to make the trackers be unique pointers? Can't they be plain members of the WebProcess and NetworkProcess classes?

> Source/WebKit2/WebProcess/WebProcess.h:382
> +    std::unique_ptr<WebSQLiteDatabaseTracker> m_webSQLiteDatabaseManager;

Should be DatabaseTracker, not DatabaseManager.

[Chris Dumez]

Created attachment 250086 [details]
Patch

[WebKit Commit Bot]

Attachment 250086 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebSQLiteDatabaseTracker.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 250086 [details]
Patch

Clearing flags on attachment: 250086

Committed r182323: <http://trac.webkit.org/changeset/182323>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.