WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143255
WebRTC: Add support for Promise-based MediaDevices.getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=143255
Summary
WebRTC: Add support for Promise-based MediaDevices.getUserMedia()
Adam Bergkvist
Reported
2015-03-30 22:35:12 PDT
MediaDevices [1] is a "name space" object that collects some functionality related to local media devices. It's, for example, home to the Promise-based version of getUserMedia() (unprefixed) and enumerateDevices(). [1]
https://w3c.github.io/mediacapture-main/#mediadevices
Attachments
Proposed patch
(47.20 KB, patch)
2015-03-31 10:51 PDT
,
Adam Bergkvist
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(48.05 KB, patch)
2015-04-02 07:59 PDT
,
Adam Bergkvist
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(48.05 KB, patch)
2015-04-02 09:07 PDT
,
Adam Bergkvist
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Adam Bergkvist
Comment 1
2015-03-31 10:51:34 PDT
Created
attachment 249834
[details]
Proposed patch
Eric Carlson
Comment 2
2015-04-02 06:37:37 PDT
Comment on
attachment 249834
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=249834&action=review
> LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html:20 > +<body> > +<p id="description"></p> > +<div id="console"></div> > +<script> > +description("Tests getUserMedia (Promise-based version on navigator.mediaDevices)"); > + > +function setUserMediaPermission(isGranted) { > + if (window.testRunner) > + testRunner.setUserMediaPermission(isGranted); > + else > + debug("This test can not be run without the testRunner"); > +} > + > +var stream; > +var errorArg;
Nit: I think this would be slightly easier to read and understand if it was indented.
> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:204 > RefPtr<NavigatorUserMediaError> error = NavigatorUserMediaError::create(NavigatorUserMediaError::permissionDeniedErrorName(), emptyString());
Shouldn't this be a MediaStreamError? If so, please add a FIXME: with a bug.
Adam Bergkvist
Comment 3
2015-04-02 07:20:58 PDT
(In reply to
comment #2
)
> Nit: I think this would be slightly easier to read and understand if it was > indented.
I found a few different styles among the tests, but most tests within the mediastream module seems to be indented so I'll align this test.
> > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:204 > > RefPtr<NavigatorUserMediaError> error = NavigatorUserMediaError::create(NavigatorUserMediaError::permissionDeniedErrorName(), emptyString()); > > Shouldn't this be a MediaStreamError? If so, please add a FIXME: with a bug.
I'll do that. Thanks for reviewing.
Adam Bergkvist
Comment 4
2015-04-02 07:59:57 PDT
Created
attachment 249978
[details]
Patch for landing
Adam Bergkvist
Comment 5
2015-04-02 08:53:06 PDT
Comment on
attachment 249978
[details]
Patch for landing Bots all green, setting cq+
WebKit Commit Bot
Comment 6
2015-04-02 08:55:14 PDT
Comment on
attachment 249978
[details]
Patch for landing Rejecting
attachment 249978
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 249978, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output:
http://webkit-queues.appspot.com/results/5272158381015040
Adam Bergkvist
Comment 7
2015-04-02 09:07:17 PDT
Created
attachment 249983
[details]
Patch for landing With reviewer name this time.
WebKit Commit Bot
Comment 8
2015-04-02 10:38:10 PDT
Comment on
attachment 249983
[details]
Patch for landing Clearing flags on attachment: 249983 Committed
r182275
: <
http://trac.webkit.org/changeset/182275
>
WebKit Commit Bot
Comment 9
2015-04-02 10:38:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug