Bug 143040 – Migrate update-webkit for Windows to not require Cygwin

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Migrate update-webkit-dependency to raw Perl

[Myles C. Maxfield]

Created attachment 249386 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 249386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249386&action=review

> Tools/Scripts/update-webkit-dependency:131
> +#$result = system "unzip", "-q", "-d", $tmpAbsDir, "$tmpAbsDir/$zipFile";

Whoops

[Myles C. Maxfield]

Created attachment 249415 [details]
Patch

[Brent Fulgham]

The updated Perl code no longer works under Cygwin. I know the goal is to get rid of Cygwin, but we can't land anything that will break the build system.

I'm debugging this now to see why it doesn't work (it seems like it should be fine). It might just be a missing Perl dependency.

[Brent Fulgham]

It looks like making sure the Cygwin install has the Perl SSL stuff installed, and then doing:

cpan LWP::Protocol::https

is sufficient to get things working.

[Brent Fulgham]

Comment on attachment 249415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249415&action=review

> Tools/Scripts/update-webkit-dependency:98
>          print STDERR "Please ensure that $libsURL is reachable.\n";

Please add an error message indicating that Perl LWP::Simple may be missing https support.

[Myles C. Maxfield]

Committed r181977: <http://trac.webkit.org/changeset/181977>

[Csaba Osztrogonác]

(In reply to comment #7)
> Committed r181977: <http://trac.webkit.org/changeset/181977>

It broke the WinCairo bot, see bug143086 for details.

[Myles C. Maxfield]

Comment on attachment 249415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249415&action=review

Overall comments

> Tools/Scripts/webkitdirs.pm:1529
> +            my $ret = system "setx", $variable, $variablesToSet{$variable};

This almost certainly does not do what I expected.