Bug 143040 - Migrate update-webkit for Windows to not require Cygwin
Summary: Migrate update-webkit for Windows to not require Cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 143086
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-24 22:48 PDT by Myles C. Maxfield
Modified: 2015-04-07 23:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2015-03-24 22:49 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2015-03-25 11:08 PDT, Myles C. Maxfield
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-03-24 22:48:02 PDT
Migrate update-webkit-dependency to raw Perl
Comment 1 Myles C. Maxfield 2015-03-24 22:49:22 PDT
Created attachment 249386 [details]
Patch
Comment 2 Myles C. Maxfield 2015-03-24 23:13:13 PDT
Comment on attachment 249386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249386&action=review

> Tools/Scripts/update-webkit-dependency:131
> +#$result = system "unzip", "-q", "-d", $tmpAbsDir, "$tmpAbsDir/$zipFile";

Whoops
Comment 3 Myles C. Maxfield 2015-03-25 11:08:58 PDT
Created attachment 249415 [details]
Patch
Comment 4 Brent Fulgham 2015-03-25 12:03:58 PDT
The updated Perl code no longer works under Cygwin. I know the goal is to get rid of Cygwin, but we can't land anything that will break the build system.

I'm debugging this now to see why it doesn't work (it seems like it should be fine). It might just be a missing Perl dependency.
Comment 5 Brent Fulgham 2015-03-25 12:36:17 PDT
It looks like making sure the Cygwin install has the Perl SSL stuff installed, and then doing:

cpan LWP::Protocol::https

is sufficient to get things working.
Comment 6 Brent Fulgham 2015-03-25 12:39:00 PDT
Comment on attachment 249415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249415&action=review

> Tools/Scripts/update-webkit-dependency:98
>          print STDERR "Please ensure that $libsURL is reachable.\n";

Please add an error message indicating that Perl LWP::Simple may be missing https support.
Comment 7 Myles C. Maxfield 2015-03-25 15:47:26 PDT
Committed r181977: <http://trac.webkit.org/changeset/181977>
Comment 8 Csaba Osztrogonác 2015-03-26 01:11:12 PDT
(In reply to comment #7)
> Committed r181977: <http://trac.webkit.org/changeset/181977>

It broke the WinCairo bot, see bug143086 for details.
Comment 9 Myles C. Maxfield 2015-04-07 23:18:13 PDT
Comment on attachment 249415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249415&action=review

Overall comments

> Tools/Scripts/webkitdirs.pm:1529
> +            my $ret = system "setx", $variable, $variablesToSet{$variable};

This almost certainly does not do what I expected.