Bug 142888 - REGRESSION (r181358): nicescroll.js main-frame scrolling override is broken
Summary: REGRESSION (r181358): nicescroll.js main-frame scrolling override is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
: 143054 (view as bug list)
Depends on:
Reported: 2015-03-19 18:03 PDT by Tim Horton
Modified: 2019-02-06 09:19 PST (History)
9 users (show)

See Also:

Patch (98.45 KB, patch)
2015-03-26 16:45 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (104.97 KB, patch)
2015-03-26 17:15 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-03-19 18:03:38 PDT
Steps to Reproduce:

1. Load http://areaaperta.com/nicescroll/
2. Scroll horizontally on the page.


Horizontal scrolling should be converted to vertical scrolling.
And, scrolling the main frame should feel bizarre (wrong acceleration).


Horizontal scrolling rubber-bands and/or swipes.
Scrolling feels normal.


This regressed in http://trac.webkit.org/changeset/181358.
Comment 1 Radar WebKit Bug Importer 2015-03-19 18:04:40 PDT
Comment 2 Darin Adler 2015-03-20 09:37:39 PDT
Ouch! If this was closer to the time I made the change I would say "just roll out". We’ll need to reduce this to a smaller test case to see what caused it. I can’t work on that until tonight. Is there someone who wants to start tracking it down?
Comment 3 Tim Horton 2015-03-26 13:17:54 PDT
The root cause is that ("ontouchstart" in window) is true now, and was false before.
Comment 4 Tim Horton 2015-03-26 13:19:25 PDT
People are using that for feature detection... but it looks like the patch intentionally changed it?
Comment 5 Tim Horton 2015-03-26 14:20:48 PDT
Also affects apple.com/watch
Comment 6 Tim Horton 2015-03-26 15:41:22 PDT
*** Bug 143054 has been marked as a duplicate of this bug. ***
Comment 7 Tim Horton 2015-03-26 16:45:35 PDT
Created attachment 249542 [details]
Comment 8 Beth Dakin 2015-03-26 16:51:40 PDT
Comment on attachment 249542 [details]

I think that there are platform-specific results for at least one of those layout tests in both mavericks and win that you will need to update.
Comment 9 Tim Horton 2015-03-26 17:15:26 PDT
Created attachment 249544 [details]
Comment 10 Tim Horton 2015-03-26 18:03:36 PDT
Comment 11 Lucas Forschler 2019-02-06 09:19:00 PST
Mass move bugs into the DOM component.