Bug 142717 - [EFL][GTK] Fix build break after r181514
Summary: [EFL][GTK] Fix build break after r181514
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-15 18:24 PDT by Hunseop Jeong
Modified: 2015-03-15 19:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2015-03-15 18:28 PDT, Hunseop Jeong 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-03-15 18:24:27 PDT 
../../Source/WebCore/html/HTMLInputElement.cpp: In member function 'void WebCore::HTMLInputElement::runPostTypeUpdateTasks()':
../../Source/WebCore/html/HTMLInputElement.cpp:521:52: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::HTMLInputElement* const)'
../../Source/WebCore/html/HTMLInputElement.cpp:521:52: note: candidate is:
In file included from ../../Source/WebCore/dom/Element.h:29:0,
                 from ../../Source/WebCore/dom/StyledElement.h:31,
                 from ../../Source/WebCore/html/HTMLElement.h:26,
                 from ../../Source/WebCore/html/LabelableElement.h:34,
                 from ../../Source/WebCore/html/HTMLFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27,
                 from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLInputElement.h:29,
                 from ../../Source/WebCore/html/HTMLInputElement.cpp:30:
../../Source/WebCore/html/HTMLInputElement.cpp:523:55: error: no matching function for call to 'WebCore::Document::didRemoveTouchEventHandler(WebCore::HTMLInputElement* const)'
../../Source/WebCore/html/HTMLInputElement.cpp:523:55: note: candidate is:
In file included from ../../Source/WebCore/dom/Element.h:29:0,
                 from ../../Source/WebCore/dom/StyledElement.h:31,
                 from ../../Source/WebCore/html/HTMLElement.h:26,
                 from ../../Source/WebCore/html/LabelableElement.h:34,
                 from ../../Source/WebCore/html/HTMLFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27,
                 from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLInputElement.h:29,
                 from ../../Source/WebCore/html/HTMLInputElement.cpp:30:
../../Source/WebCore/html/HTMLInputElement.cpp:1518:48: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::HTMLInputElement* const)'
../../Source/WebCore/html/HTMLInputElement.cpp:1518:48: note: candidate is:
In file included from ../../Source/WebCore/dom/Element.h:29:0,
                 from ../../Source/WebCore/dom/StyledElement.h:31,
                 from ../../Source/WebCore/html/HTMLElement.h:26,
                 from ../../Source/WebCore/html/LabelableElement.h:34,
                 from ../../Source/WebCore/html/HTMLFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27,
                 from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28,
                 from ../../Source/WebCore/html/HTMLInputElement.h:29,
                 from ../../Source/WebCore/html/HTMLInputElement.cpp:30:
../../Source/WebCore/dom/Document.cpp: In member function 'void WebCore::Document::didAddTouchEventHandler(WebCore::Node&)':
../../Source/WebCore/dom/Document.cpp:6018:45: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::Document* const)'
../../Source/WebCore/dom/Document.cpp:6018:45: note: candidate is:
../../Source/WebCore/dom/Document.cpp:6011:6: note: void WebCore::Document::didAddTouchEventHandler(WebCore::Node&)
../../Source/WebCore/dom/Document.cpp:6011:6: note:   no known conversion for argument 1 from 'WebCore::Document* const' to 'WebCore::Node&'
../../Source/WebCore/dom/Document.cpp: In member function 'void WebCore::Document::didRemoveTouchEventHandler(WebCore::Node&)':
../../Source/WebCore/dom/Document.cpp:6038:48: error: no matching function for call to 'WebCore::Document::didRemoveTouchEventHandler(WebCore::Document* const)'
../../Source/WebCore/dom/Document.cpp:6038:48: note: candidate is:
../../Source/WebCore/dom/Document.cpp:6030:6: note: void WebCore::Document::didRemoveTouchEventHandler(WebCore::Node&)
../../Source/WebCore/dom/Document.cpp:6030:6: note:   no known conversion for argument 1 from 'WebCore::Document* const' to 'WebCore::Node&'
Comment 1 Hunseop Jeong 2015-03-15 18:28:44 PDT 
Created attachment 248695 [details]
Patch
Comment 2 Gyuyoung Kim 2015-03-15 19:08:57 PDT 
r181514 passed to EFL EWS on Bug 142713. I wonder why EFL bot is broken.
Comment 3 Gyuyoung Kim 2015-03-15 19:26:01 PDT 
(In reply to comment #2)
> r181514 passed to EFL EWS on Bug 142713. I wonder why EFL bot is broken.

Looks like simon just fixes this break - https://trac.webkit.org/r181519
Comment 4 Simon Fraser (smfr) 2015-03-15 19:28:04 PDT 
Comment on attachment 248695 [details]
Patch

Thanks. Committed in https://trac.webkit.org/r181519 and https://trac.webkit.org/r181520.