Bug 142713 - Clean up related to wheelEvent names
Summary: Clean up related to wheelEvent names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-15 15:01 PDT by Simon Fraser (smfr)
Modified: 2015-03-15 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.50 KB, patch)
2015-03-15 15:03 PDT, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-03-15 15:01:22 PDT 
Clean up related to wheelEvent names
Comment 1 Simon Fraser (smfr) 2015-03-15 15:03:15 PDT 
Created attachment 248689 [details]
Patch
Comment 2 Anders Carlsson 2015-03-15 15:04:24 PDT 
Comment on attachment 248689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248689&action=review

> Source/WebCore/dom/Document.cpp:5998
> +void Document::didAddWheelEventHandler(Node*)

Can Node be a reference?

> Source/WebCore/dom/Document.cpp:6004
> +void Document::didRemoveWheelEventHandler(Node*)

Same question here.
Comment 3 Simon Fraser (smfr) 2015-03-15 15:48:12 PDT 
https://trac.webkit.org/r181514