Bug 142493 - [EFL] Move DispatchQueue to WTF
Summary: [EFL] Move DispatchQueue to WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 142473
  Show dependency treegraph
 
Reported: 2015-03-09 08:05 PDT by Martin Robinson
Modified: 2015-03-09 10:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (31.49 KB, patch)
2015-03-09 08:11 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (31.52 KB, patch)
2015-03-09 09:36 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2015-03-09 08:05:28 PDT
Now that WorkQueue has moved to WTF, it makes sense that DispatchQueue should move there as well.
Comment 1 Martin Robinson 2015-03-09 08:11:09 PDT
Created attachment 248244 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-09 08:13:39 PDT
Attachment 248244 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:214:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2015-03-09 09:30:10 PDT
Comment on attachment 248244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248244&action=review

rs=me with the buildfix included.

> Source/WTF/wtf/PlatformEfl.cmake:-26
> -    "${WEBKIT2_DIR}/Platform/efl"

"${WTF_DIR}/wtf/efl" should be added and EFL will build.
Comment 4 Martin Robinson 2015-03-09 09:36:51 PDT
Created attachment 248248 [details]
Patch
Comment 5 WebKit Commit Bot 2015-03-09 09:38:56 PDT
Attachment 248248 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:214:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Csaba Osztrogonác 2015-03-09 09:43:56 PDT
ninja: error: '../../Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h', needed by 'WebKit2-forwarding-headers.stamp', missing and no known rule to make it

Maybe we need some hint mechanism to make GTK build force 
rerun cmake to avoid this kind of incremental build issues.

What about adding a dummy file which would trigger cmake
rerun if you touch it? It would solve this problesm for
buildbots, EWS bots and all developers.
Comment 7 Anders Carlsson 2015-03-09 09:44:29 PDT
Is DispatchQueue an implementation detail of WTF or is it its own thing?
Comment 8 Martin Robinson 2015-03-09 09:56:47 PDT
(In reply to comment #7)
> Is DispatchQueue an implementation detail of WTF or is it its own thing?

It's an implementation detail of the WorkQueue. I couldn't find any uses apart from WorkQueue, but perhaps ossy can correct me.
Comment 9 Csaba Osztrogonác 2015-03-09 10:04:34 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > Is DispatchQueue an implementation detail of WTF or is it its own thing?
> 
> It's an implementation detail of the WorkQueue. I couldn't find any uses
> apart from WorkQueue, but perhaps ossy can correct me.

I think you're right, I couldn't find any other use. ( Just a note, DispatchQueue
was separated from WorkQueue by http://trac.webkit.org/changeset/157289 )
Comment 10 Csaba Osztrogonác 2015-03-09 10:05:38 PDT
Comment on attachment 248248 [details]
Patch

still r=me
Comment 11 Martin Robinson 2015-03-09 10:07:19 PDT
Okay. I'll land this and trigger a clean build on the GTK+ bots.
Comment 12 WebKit Commit Bot 2015-03-09 10:49:45 PDT
Comment on attachment 248248 [details]
Patch

Clearing flags on attachment: 248248

Committed r181271: <http://trac.webkit.org/changeset/181271>
Comment 13 WebKit Commit Bot 2015-03-09 10:49:48 PDT
All reviewed patches have been landed.  Closing bug.