Bug 142493 – [EFL] Move DispatchQueue to WTF

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Martin Robinson]

Now that WorkQueue has moved to WTF, it makes sense that DispatchQueue should move there as well.

[Martin Robinson]

Created attachment 248244 [details]
Patch

[WebKit Commit Bot]

Attachment 248244 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:214:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

Comment on attachment 248244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248244&action=review

rs=me with the buildfix included.

> Source/WTF/wtf/PlatformEfl.cmake:-26
> -    "${WEBKIT2_DIR}/Platform/efl"

"${WTF_DIR}/wtf/efl" should be added and EFL will build.

[Martin Robinson]

Created attachment 248248 [details]
Patch

[WebKit Commit Bot]

Attachment 248248 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.cpp:214:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueEfl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

ninja: error: '../../Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h', needed by 'WebKit2-forwarding-headers.stamp', missing and no known rule to make it

Maybe we need some hint mechanism to make GTK build force 
rerun cmake to avoid this kind of incremental build issues.

What about adding a dummy file which would trigger cmake
rerun if you touch it? It would solve this problesm for
buildbots, EWS bots and all developers.

[Anders Carlsson]

Is DispatchQueue an implementation detail of WTF or is it its own thing?

[Martin Robinson]

(In reply to comment #7)
> Is DispatchQueue an implementation detail of WTF or is it its own thing?

It's an implementation detail of the WorkQueue. I couldn't find any uses apart from WorkQueue, but perhaps ossy can correct me.

[Csaba Osztrogonác]

(In reply to comment #8)
> (In reply to comment #7)
> > Is DispatchQueue an implementation detail of WTF or is it its own thing?
> 
> It's an implementation detail of the WorkQueue. I couldn't find any uses
> apart from WorkQueue, but perhaps ossy can correct me.

I think you're right, I couldn't find any other use. ( Just a note, DispatchQueue
was separated from WorkQueue by http://trac.webkit.org/changeset/157289 )

[Csaba Osztrogonác]

Comment on attachment 248248 [details]
Patch

still r=me

[Martin Robinson]

Okay. I'll land this and trigger a clean build on the GTK+ bots.

[WebKit Commit Bot]

Comment on attachment 248248 [details]
Patch

Clearing flags on attachment: 248248

Committed r181271: <http://trac.webkit.org/changeset/181271>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.