Bug 142338 - [cmake] Handle unused parameter warnings as build errors except in WebKit2
Summary: [cmake] Handle unused parameter warnings as build errors except in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on: 142497
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-05 06:10 PST by Csaba Osztrogonác
Modified: 2015-03-10 01:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2015-03-05 06:13 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2015-03-09 12:10 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-03-05 06:10:11 PST 
To match the actual Mac settings, we should handle unused parameter warnings
as build build errors, except in WebKit2. In WebKit2, we should simply
suppress them, because Mac port does the same, there is no reason to
newly introduced unused parameter warnings in WebKit2 again and again.
Comment 1 Csaba Osztrogonác 2015-03-05 06:13:23 PST 
Created attachment 247948 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-05 06:23:19 PST 
webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2015-March/027269.html
Comment 3 Csaba Osztrogonác 2015-03-05 06:28:38 PST 
(In reply to comment #0)
> To match the actual Mac settings, we should handle unused parameter warnings
> as build build errors, except in WebKit2. In WebKit2, we should simply
> suppress them, because Mac port does the same, there is no reason to
> newly introduced unused parameter warnings in WebKit2 again and again.

typo: ... no reason to _fix_ newly ...
Comment 4 Gyuyoung Kim 2015-03-05 17:46:17 PST 
Comment on attachment 247948 [details]
Patch

Nobody replied this mail thread. So let's omit to make sound of unused param warning in WebKit2 as Mac port.
Comment 5 Csaba Osztrogonác 2015-03-09 12:10:48 PDT 
Created attachment 248267 [details]
Patch

patch for landing, last EWS check to make sure we won't break the build.
Comment 6 WebKit Commit Bot 2015-03-10 01:33:59 PDT 
Comment on attachment 248267 [details]
Patch

Clearing flags on attachment: 248267

Committed r181318: <http://trac.webkit.org/changeset/181318>
Comment 7 WebKit Commit Bot 2015-03-10 01:34:02 PDT 
All reviewed patches have been landed.  Closing bug.