Bug 142017 - [Win] [Attachment] New Tests fail on Windows
Summary: [Win] [Attachment] New Tests fail on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
Depends on: 141993
  Show dependency treegraph
Reported: 2015-02-25 09:33 PST by Brent Fulgham
Modified: 2015-03-04 09:37 PST (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-02-25 09:33:18 PST
The new <attachment> stuff added in <https://trac.webkit.org/changeset/180601> does not seem to work properly on Windows.

The following layout test is failing on Windows


The Failing looks like the following:
--- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-expected.txt
+++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-actual.txt
@@ -1,14 +1,10 @@
+CONSOLE MESSAGE: line 1: ReferenceError: Can't find variable: HTMLAttachmentElement
 This tests that attachments have an instance type of HTMLElement.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS attachment is an instance of HTMLAttachmentElement
-PASS attachment.file is null
-Setting attachment.file to a file created from resources/test-file.txt
-PASS attachment.file is file
-PASS attachment.file.name is 'test-file.txt'
-PASS successfullyParsed is true
+FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
Comment 1 Brent Fulgham 2015-02-25 09:36:27 PST
Failing test skipped on Windows in r180629. <https://trac.webkit.org/r180629>
Comment 2 Brent Fulgham 2015-03-03 21:29:32 PST
Committed r180990: <http://trac.webkit.org/changeset/180990>
Comment 3 Brent Fulgham 2015-03-03 21:30:19 PST
This needed two things:
1. Activate the feature on Windows.
2. Update baselines for Windows display metrics.
Comment 4 Alexey Proskuryakov 2015-03-04 00:53:03 PST
This broke Windows build:

     1>C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error C2065: 'CSSValueAttachment' : undeclared identifier (C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder.cpp)
Comment 5 Brent Fulgham 2015-03-04 09:37:37 PST
(In reply to comment #4)
> This broke Windows build:
> 1>C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error
> C2065: 'CSSValueAttachment' : undeclared identifier
> (C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder.
> cpp)

Fixed with a clean build. But see also Bug 142284, where we are fixing this problem permanently.