RESOLVED FIXED 142017
[Win] [Attachment] New Tests fail on Windows 
https://bugs.webkit.org/show_bug.cgi?id=142017
Summary [Win] [Attachment] New Tests fail on Windows
Brent Fulgham
Reported 2015-02-25 09:33:18 PST
The new <attachment> stuff added in <https://trac.webkit.org/changeset/180601> does not seem to work properly on Windows. The following layout test is failing on Windows fast/attachment/attachment-dom.html The Failing looks like the following: --- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-expected.txt +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-dom-actual.txt @@ -1,14 +1,10 @@ +CONSOLE MESSAGE: line 1: ReferenceError: Can't find variable: HTMLAttachmentElement This tests that attachments have an instance type of HTMLElement. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS attachment is an instance of HTMLAttachmentElement -PASS attachment.file is null -Setting attachment.file to a file created from resources/test-file.txt -PASS attachment.file is file -PASS attachment.file.name is 'test-file.txt' -PASS successfullyParsed is true +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-02-25 09:36:27 PST
Failing test skipped on Windows in r180629. <https://trac.webkit.org/r180629>
Brent Fulgham
Comment 2 2015-03-03 21:29:32 PST
Committed r180990: <http://trac.webkit.org/changeset/180990>
Brent Fulgham
Comment 3 2015-03-03 21:30:19 PST
This needed two things: 1. Activate the feature on Windows. 2. Update baselines for Windows display metrics.
Alexey Proskuryakov
Comment 4 2015-03-04 00:53:03 PST
This broke Windows build: 1>C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error C2065: 'CSSValueAttachment' : undeclared identifier (C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder.cpp)
Brent Fulgham
Comment 5 2015-03-04 09:37:37 PST
(In reply to comment #4) > This broke Windows build: > > > 1>C:\cygwin\home\buildbot\slave\win- > release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error > C2065: 'CSSValueAttachment' : undeclared identifier > (C:\cygwin\home\buildbot\slave\win- > release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder. > cpp) Fixed with a clean build. But see also Bug 142284, where we are fixing this problem permanently.
Note You need to log in before you can comment on or make changes to this bug.