Bug 141993 – [Attachment] Give <attachment> elements an underlying File

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Attachment] Give <attachment> elements an underlying File

[Sam Weinig]

Created attachment 247284 [details]
Patch

[Tim Horton]

Comment on attachment 247284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247284&action=review

> Source/WebCore/DerivedSources.cpp:174
> +#if ENABLE(ATTACHMENT_ELEMENT)

Shouldn't this be below in its own block?

> LayoutTests/fast/attachment/attachment-dom.html:16
> +if (window.internals) {

no braces

[Simon Fraser (smfr)]

This broke windows:

     1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(607,5): error MSB6006: "link.exe" exited with code 1120.
     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: class WTF::String __thiscall WebCore::URL::fileSystemPath(void)const " (?fileSystemPath@URL@WebCore@@QBE?AVString@WTF@@XZ) referenced in function "public: class WTF::RefPtr<class WebCore::File> __thiscall WebCore::Internals::createFile(class WTF::String const &)" (?createFile@Internals@WebCore@@QAE?AV?$RefPtr@VFile@WebCore@@@WTF@@ABVString@4@@Z)
     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall WebCore::URL::isLocalFile(void)const " (?isLocalFile@URL@WebCore@@QBE_NXZ) referenced in function "public: class WTF::RefPtr<class WebCore::File> __thiscall WebCore::Internals::createFile(class WTF::String const &)" (?createFile@Internals@WebCore@@QAE?AV?$RefPtr@VFile@WebCore@@@WTF@@ABVString@4@@Z)
     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "private: __thiscall WebCore::File::File(class WTF::String const &)" (??0File@WebCore@@AAE@ABVString@WTF@@@Z) referenced in function "public: static class WTF::Ref<class WebCore::File> __cdecl WebCore::File::create(class WTF::String const &)" (?create@File@WebCore@@SA?AV?$Ref@VFile@WebCore@@@WTF@@ABVString@4@@Z)
     1>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::File *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVFile@1@@Z) referenced in function "public: float __thiscall <lambda_61e80db43a2fdfc51022831809c4282b>::operator()(class WebCore::LayoutUnit,class WebCore::LayoutUnit)const " (??R<lambda_61e80db43a2fdfc51022831809c4282b>@@QBEMVLayoutUnit@WebCore@@0@Z)
     1>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin32\DumpRenderTree.dll : fatal error LNK1120: 4 unresolved externals

Should have waited for EWS!

[Simon Fraser (smfr)]

Brent tried to fix in https://trac.webkit.org/r180610.

[Alexey Proskuryakov]

This also broke js/dom/global-constructors-attributes.html on Mac. Updated the results in r180616.

Should have waited for EWS!

[Ryosuke Niwa]

Comment on attachment 247284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247284&action=review

> Source/WebCore/html/HTMLAttachmentElement.idl:27
> +    Conditional=ATTACHMENT_ELEMENT

We shoudln't be generating interface object in window.
It's causing global-constructors-attributes.html to see this interface.

See https://trac.webkit.org/r180616.

[Ryosuke Niwa]

Oh interesting, this feature is runtime-enabled by default.