Bug 14193 - Move the Screen object out of the JS bindings
Summary: Move the Screen object out of the JS bindings
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 14192
  Show dependency treegraph
Reported: 2007-06-16 19:48 PDT by Sam Weinig
Modified: 2007-06-18 17:21 PDT (History)
0 users

See Also:

patch (77.17 KB, patch)
2007-06-16 20:12 PDT, Sam Weinig
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-06-16 19:48:16 PDT
Forthcoming patch moves the Screen object out of the JS bindings code and autogenerates a wrapper instead.
Comment 1 Sam Weinig 2007-06-16 20:12:36 PDT
Created attachment 15081 [details]
Comment 2 Sam Weinig 2007-06-16 20:16:24 PDT
One change from the old code that this patch makes is that the properties of the Screen object used to be DontEnum|ReadOnly and now are DontDelete|ReadOnly.  I found no documentation or reason that the screen properties should be non-enumeratable and deletable so I changed them to be just like all the the other js objects we generate.   This change is visible in the changed results of the regression tests.
Comment 3 Geoffrey Garen 2007-06-18 11:23:42 PDT
Comment on attachment 15081 [details]


Will the other platforms' projects need to change to accommodate the new file paths? Maybe you should send email to webkit-dev.
Comment 4 Sam Weinig 2007-06-18 17:21:21 PDT
Landed in r23576.