Bug 141904 - UNREACHABLE_FOR_PLATFORM() should be release assert
Summary: UNREACHABLE_FOR_PLATFORM() should be release assert
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 06:20 PST by Csaba Osztrogonác
Modified: 2015-02-26 02:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2015-02-23 06:21 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-23 06:20:00 PST 
UNREACHABLE_FOR_PLATFORM() should be release assert
Comment 1 Csaba Osztrogonác 2015-02-23 06:21:15 PST 
Created attachment 247114 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-02-23 06:25:36 PST 
Now it is relase assert with clang, but debug assert otherwise.
Additionally RELEASE_ASSERT_NOT_REACHED(); is simple crash in
release mode, but it is more verbose in debug mode.

Releated discussion can be found here:
https://bugs.webkit.org/show_bug.cgi?id=141489#c10 ( and c11, c12 )

just a note: It depends on bug141903. We should wait until 
bug141903 is fixed not to break the ARM traditional world.
Comment 3 WebKit Commit Bot 2015-02-26 02:51:16 PST 
Comment on attachment 247114 [details]
Patch

Clearing flags on attachment: 247114

Committed r180668: <http://trac.webkit.org/changeset/180668>
Comment 4 WebKit Commit Bot 2015-02-26 02:51:19 PST 
All reviewed patches have been landed.  Closing bug.