Bug 141902 – Remove unnecessary create() factory functions in CDMFoo, NamedNodeMap

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Gyuyoung Kim]

Though create() factory functions do nothing, CDMFoo, NamedNodeMap have used create() factory. Even some of create() factory used std::unique_ptr<> instead of std::make_unique<>.

[Gyuyoung Kim]

Created attachment 247110 [details]
Patch

[Gyuyoung Kim]

Created attachment 247111 [details]
Patch

[Gyuyoung Kim]

Created attachment 247172 [details]
Patch

[Gyuyoung Kim]

Created attachment 247211 [details]
Patch

[Gyuyoung Kim]

Created attachment 247222 [details]
Patch for win

[Gyuyoung Kim]

Created attachment 247233 [details]
Patch

[Gyuyoung Kim]

Created attachment 247292 [details]
Patch

[Build Bot]

Comment on attachment 247292 [details]
Patch

Attachment 247292 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4548557155598336

New failing tests:
fast/loader/text-document-wrapping.html
tables/mozilla/bugs/bug139524-2.html

[Build Bot]

Created attachment 247302 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Gyuyoung Kim]

Comment on attachment 247292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247292&action=review

> Source/WebCore/testing/Internals.cpp:2129
> +    CDM::registerCDMFactory([](CDM* cdm) { return std::make_unique<MockCDM>(cdm); },

Brent, I have failed to pass win ews for this use. Win EWS reported a build error as below,


 1>WebKit.exp : error LNK2001: unresolved external symbol "public: static void __cdecl WebCore::CDM::registerCDMFactory(class std::unique_ptr<class WebCore::CDMPrivateInterface,struct std::default_delete<class WebCore::CDMPrivateInterface> > (__cdecl*)(class WebCore::CDM *),bool (__cdecl*)(class WTF::String const &),bool (__cdecl*)(class WTF::String const &,class WTF::String const &))" (?registerCDMFactory@CDM@WebCore@@SAXP6A?AV?$unique_ptr@VCDMPrivateInterface@WebCore@@U?$default_delete@VCDMPrivateInterface@WebCore@@@std@@@std@@PAV12@@ZP6A_NABVString@WTF@@@ZP6A_N22@Z@Z)
     1>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals
     1>Done Building Project "C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj" (Build tar


Could you help to fix this problem ?

[Darin Adler]

That problem should go away once Brent commits the fix for bug 141734 and we rebase against it (or just get EWS to run again).

[Brent Fulgham]

(In reply to comment #11)
> That problem should go away once Brent commits the fix for bug 141734 and we
> rebase against it (or just get EWS to run again).

Yes! I think we are just a few minutes away from this ceasing to be a problem anymore. :-)

[Brent Fulgham]

Your patch should work once I close Bug 141732.

[Gyuyoung Kim]

Created attachment 247406 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #13)
> Your patch should work once I close Bug 141732.

Thanks, try again !

[Brent Fulgham]

(In reply to comment #15)
> (In reply to comment #13)
> > Your patch should work once I close Bug 141732.
> 
> Thanks, try again !

It worked! Whoo-hoo! :-)

[Gyuyoung Kim]

(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #13)
> > > Your patch should work once I close Bug 141732.
> > 
> > Thanks, try again !
> 
> It worked! Whoo-hoo! :-)

He He Thanks :)

[WebKit Commit Bot]

Comment on attachment 247406 [details]
Patch

Clearing flags on attachment: 247406

Committed r180712: <http://trac.webkit.org/changeset/180712>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.