Bug 141749 - Purge PassRefPtr from CanvasRenderingContext2D.
Summary: Purge PassRefPtr from CanvasRenderingContext2D.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Blocks: 144092
  Show dependency treegraph
Reported: 2015-02-18 01:16 PST by Andreas Kling
Modified: 2015-04-23 01:47 PDT (History)
3 users (show)

See Also:

Patch (14.95 KB, patch)
2015-02-18 01:33 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-02-18 01:16:22 PST
Let's get rid of PassRefPtr usage from CanvasRenderingContext2D.
Comment 1 Andreas Kling 2015-02-18 01:33:00 PST
Created attachment 246809 [details]
Comment 2 WebKit Commit Bot 2015-02-18 01:33:55 PST
Attachment 246809 [details] did not pass style-queue:

ERROR: Source/WebCore/html/canvas/CanvasRenderingContext2D.h:342:  The parameter name "gradient" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2015-02-18 03:51:22 PST
Comment on attachment 246809 [details]

Comment 4 WebKit Commit Bot 2015-02-18 09:52:29 PST
Comment on attachment 246809 [details]

Clearing flags on attachment: 246809

Committed r180268: <http://trac.webkit.org/changeset/180268>
Comment 5 WebKit Commit Bot 2015-02-18 09:52:33 PST
All reviewed patches have been landed.  Closing bug.