Bug 141715 - Cleanup: Use @memoized for property IOSSimulator.testing_device
Summary: Cleanup: Use @memoized for property IOSSimulator.testing_device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 141711
Blocks:
  Show dependency tree / graph
 
Reported: 2015-02-17 10:18 PST by Daniel Bates
Modified: 2015-04-24 14:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2015-02-17 10:22 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2015-04-23 15:52 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-02-17 10:18:03 PST 
We can simplify the logic in IOSSimulatorPort for caching the testing device by using the @memoized decorator.
Comment 1 Daniel Bates 2015-02-17 10:22:09 PST 
Created attachment 246753 [details]
Patch
Comment 2 Daniel Bates 2015-04-23 15:52:41 PDT 
Created attachment 251504 [details]
Patch
Comment 3 Jake Nielsen 2015-04-23 16:37:47 PDT 
Nice!
Comment 4 Daniel Bates 2015-04-24 14:40:13 PDT 
Comment on attachment 251504 [details]
Patch

Clearing flags on attachment: 251504

Committed r183281: <http://trac.webkit.org/changeset/183281>
Comment 5 Daniel Bates 2015-04-24 14:40:19 PDT 
All reviewed patches have been landed.  Closing bug.