Bug 141711 - run_webkit_tests.py should not know about iOS Simulator details
Summary: run_webkit_tests.py should not know about iOS Simulator details
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks: 141715 141718
  Show dependency treegraph
 
Reported: 2015-02-17 09:50 PST by Daniel Bates
Modified: 2015-02-17 14:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.54 KB, patch)
2015-02-17 09:56 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-02-17 09:50:38 PST
run_webkit_tests.py should only parse the iOS Simulator command line options --runtime and --device-type. The IOSSimulatorPort object should be responsible for validating these parsed values and instantiating internal data structures to represent them.
Comment 1 Daniel Bates 2015-02-17 09:56:37 PST
Created attachment 246750 [details]
Patch
Comment 2 Daniel Bates 2015-02-17 14:13:19 PST
Comment on attachment 246750 [details]
Patch

Clearing flags on attachment: 246750

Committed r180238: <http://trac.webkit.org/changeset/180238>
Comment 3 Daniel Bates 2015-02-17 14:13:23 PST
All reviewed patches have been landed.  Closing bug.