.
<rdar://problem/19840602>
Created attachment 246631 [details] Proposed Fix
Comment on attachment 246631 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246631&action=review Looks good. r=me > Source/WebCore/WebCore.exp.in:1642 > +__ZN9Inspector9PageAgent7frameIdEPNS_5FrameE I don't think this file exists anymore =). > Source/WebCore/inspector/InspectorCSSAgent.h:101 > + void didCreateNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&); > + void willRemoveNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&); Arg, this is why I was afraid of moving the agents to Inspector namespace. Hopefully there aren't too many WebCore::s.
Created attachment 247538 [details] Proposed Fix (rebased)
Comment on attachment 246631 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246631&action=review >> Source/WebCore/WebCore.exp.in:1642 >> +__ZN9Inspector9PageAgent7frameIdEPNS_5FrameE > > I don't think this file exists anymore =). Yup, rebased patch has removed this chunk. >> Source/WebCore/inspector/InspectorCSSAgent.h:101 >> + void willRemoveNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&); > > Arg, this is why I was afraid of moving the agents to Inspector namespace. Hopefully there aren't too many WebCore::s. I only found the number of prefixes to be onerous in CSSAgent and DOMAgent due to the huge number of hooks. It's only for headers though, so I think it's worth it.