.
<rdar://problem/19838400>
Created attachment 246604 [details] Proposed Fix
Created attachment 246609 [details] Proposed Fix
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment on attachment 246609 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246609&action=review > Source/WebCore/inspector/CommandLineAPIHost.h:67 > + , Inspector::ConsoleAgent* consoleAgent Drop the namespace here. > Source/WebCore/inspector/CommandLineAPIHost.h:105 > + Inspector::ConsoleAgent* m_consoleAgent; Ditto.
(In reply to comment #5) > Comment on attachment 246609 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246609&action=review > > > Source/WebCore/inspector/CommandLineAPIHost.h:67 > > + , Inspector::ConsoleAgent* consoleAgent > > Drop the namespace here. > > > Source/WebCore/inspector/CommandLineAPIHost.h:105 > > + Inspector::ConsoleAgent* m_consoleAgent; > > Ditto. This class is still in WebCore namespace, and it's a header. So it can't be removed yet.
Created attachment 247521 [details] Proposed Fix (rebased)
Comment on attachment 247521 [details] Proposed Fix (rebased) r=me, looks like Win EWS is red, might be related.
This might be stale now.
Stale now for sure. Clearing flags.