Bug 141470 - run-jsc-stress-tests --remote should skip profiler tests
Summary: run-jsc-stress-tests --remote should skip profiler tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 141165
  Show dependency treegraph
 
Reported: 2015-02-11 03:49 PST by Csaba Osztrogonác
Modified: 2015-02-13 11:02 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2015-02-11 03:54 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-11 03:49:38 PST
addRunCommand("profiler", ["ruby", (pathToHelpers + "profiler-test-helper").to_s, (SCRIPTS_PATH + "display-profiler-output").to_s,
profilerOutput.to_s, pathToVM.to_s, "-p", profilerOutput.to_s, $benchmark.to_s], silentOutputHandler, simpleErrorHandler)

profiler tests now depends on many local paths:
- SCRIPTS_PATH
- profilerOutput - generated by uniqueFilename which does everything locally

I think we should simply disable profiler tests for remote testing until proper fix.
Comment 1 Csaba Osztrogonác 2015-02-11 03:54:18 PST
Created attachment 246383 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-02-13 06:51:07 PST
It's safe to land it, because these tests are are already skipped on 
non-X86 Darwin and Windows platforms. (Enabled on X86-Darwin and all 
Linux platforms)
Comment 3 Csaba Osztrogonác 2015-02-13 06:53:07 PST
https://bugs.webkit.org/show_bug.cgi?id=133149#c7 says the original goal was
to skip these tests for remote testing. So here is the proper skipping.

Filip, could you possibly review it?
Comment 4 WebKit Commit Bot 2015-02-13 11:02:02 PST
Comment on attachment 246383 [details]
Patch

Clearing flags on attachment: 246383

Committed r180061: <http://trac.webkit.org/changeset/180061>
Comment 5 WebKit Commit Bot 2015-02-13 11:02:07 PST
All reviewed patches have been landed.  Closing bug.