RESOLVED FIXED 141470
run-jsc-stress-tests --remote should skip profiler tests 
https://bugs.webkit.org/show_bug.cgi?id=141470
Summary run-jsc-stress-tests --remote should skip profiler tests
Csaba Osztrogonác
Reported 2015-02-11 03:49:38 PST
addRunCommand("profiler", ["ruby", (pathToHelpers + "profiler-test-helper").to_s, (SCRIPTS_PATH + "display-profiler-output").to_s, profilerOutput.to_s, pathToVM.to_s, "-p", profilerOutput.to_s, $benchmark.to_s], silentOutputHandler, simpleErrorHandler) profiler tests now depends on many local paths: - SCRIPTS_PATH - profilerOutput - generated by uniqueFilename which does everything locally I think we should simply disable profiler tests for remote testing until proper fix.
Attachments
Patch (1.33 KB, patch)
2015-02-11 03:54 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-11 03:54:18 PST
Created attachment 246383 [details] Patch
Csaba Osztrogonác
Comment 2 2015-02-13 06:51:07 PST
It's safe to land it, because these tests are are already skipped on non-X86 Darwin and Windows platforms. (Enabled on X86-Darwin and all Linux platforms)
Csaba Osztrogonác
Comment 3 2015-02-13 06:53:07 PST
https://bugs.webkit.org/show_bug.cgi?id=133149#c7 says the original goal was to skip these tests for remote testing. So here is the proper skipping. Filip, could you possibly review it?
WebKit Commit Bot
Comment 4 2015-02-13 11:02:02 PST
Comment on attachment 246383 [details] Patch Clearing flags on attachment: 246383 Committed r180061: <http://trac.webkit.org/changeset/180061>
WebKit Commit Bot
Comment 5 2015-02-13 11:02:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.