Bug 141417 – text-align start / end failure in table cells

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Philippe Wittenbergh]

Created attachment 246315 [details]
test case

text-align: start fails inside a <th>; the content in the cell is centred aligned instead (the default / initial value)
text-align: end fails inside a <td>; text is left-aligned instead (text-align: start appears to work, but then, text-align: left is the initial value…)

In the attached test case, I’ve set `td { text-align: center; }` this is (correctly) overridden by `text-align: start`.

Tested on 10.10.2 with Safari 8.0.3 and latest Nightly build (r179862)

[Nikita Vasilyev]

This is still relevant.

[Nikita Vasilyev]

This works as expected in Chrome and Firefox.

[Radar WebKit Bug Importer]

<rdar://problem/31051672>

[zalan]

Created attachment 307081 [details]
Patch

[Build Bot]

Comment on attachment 307081 [details]
Patch

Attachment 307081 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3532959

New failing tests:
webrtc/captureCanvas-webrtc.html

[Build Bot]

Created attachment 307110 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 307118 [details]
Patch

[Antti Koivisto]

Comment on attachment 307118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307118&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1897
>          static const unsigned styleTypeAndPaddingBitCount = styleTypeBitCount + styleTypePadding;
>          static const uint64_t styleTypeMask = (oneBitMask << styleTypeAndPaddingBitCount) - 1;
>          static const unsigned styleTypeOffset = hasViewportUnitsBitCount + hasViewportUnitsOffset;
> +        static const unsigned hasExplicitlySetTextAlignOffset = styleTypeOffset + styleTypeAndPaddingBitCount;
>  
>          // Byte 8.
> -        static const unsigned isUniqueOffset = styleTypeOffset + styleTypeAndPaddingBitCount;
> +        static const unsigned isUniqueOffset = hasExplicitlySetTextAlignOffset + 1;

You need to reduce styleTypePadding by one so since you are grabbing bit there. It would also be clearer to add hasExplicitlySetTextAlignOffset bit to the beginning of the byte 7 so that the padding stays at end.

[zalan]

Created attachment 307123 [details]
Patch

[Antti Koivisto]

r=me

[Build Bot]

Comment on attachment 307123 [details]
Patch

Attachment 307123 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3534966

New failing tests:
css2.1/t0804-c5507-padn-r-01-c-a.html
css1/box_properties/margin_right.html
fast/lists/002.html
css2.1/t0803-c5502-mrgn-r-01-c-a.html
fast/css/text-align-webkit-match-parent.html
fast/css/list-item-text-align.html
css1/box_properties/padding_right.html
fast/lists/003.html
editing/pasteboard/paste-4039777-fix.html
fast/lists/001.html
fast/lists/001-vertical.html
fast/lists/003-vertical.html
fast/lists/002-vertical.html

[Build Bot]

Created attachment 307128 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307123 [details]
Patch

Attachment 307123 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3535039

New failing tests:
css2.1/t0804-c5507-padn-r-01-c-a.html
css1/box_properties/margin_right.html
fast/lists/002.html
editing/pasteboard/paste-4039777-fix.html
fast/css/text-align-webkit-match-parent.html
fast/css/list-item-text-align.html
css1/box_properties/padding_right.html
fast/lists/003.html
css2.1/t0803-c5502-mrgn-r-01-c-a.html
fast/lists/001.html
fast/lists/001-vertical.html
fast/lists/003-vertical.html
fast/lists/002-vertical.html

[Build Bot]

Created attachment 307132 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307123 [details]
Patch

Attachment 307123 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3535115

New failing tests:
css2.1/t0804-c5507-padn-r-01-c-a.html
css1/box_properties/margin_right.html
fast/lists/002.html
css2.1/t0803-c5502-mrgn-r-01-c-a.html
fast/css/text-align-webkit-match-parent.html
fast/css/list-item-text-align.html
css1/box_properties/padding_right.html
fast/lists/003.html
editing/pasteboard/paste-4039777-fix.html
fast/lists/001.html
fast/lists/001-vertical.html
fast/lists/003-vertical.html
fast/lists/002-vertical.html

[Build Bot]

Created attachment 307133 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 307135 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 307135 [details]
Patch

Clearing flags on attachment: 307135

Committed r215375: <http://trac.webkit.org/changeset/215375>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ebrahim Byagowi]

Similar bug worths to be fixed if not yet by this: Bug 79272