Bug 169645 - REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
Summary: REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 141417
Blocks:
  Show dependency tree / graph
 
Reported: 2017-03-14 16:52 PDT by Nikita Vasilyev
Modified: 2017-04-14 23:55 PDT (History)
4 users (show)

See Also:

Attachments
[Image] "Function" column should be aligned left for LTR layout (35.09 KB, image/png)
2017-03-14 16:52 PDT, Nikita Vasilyev 		no flags Details
Patch (1.57 KB, patch)
2017-03-15 12:13 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-03-14 16:52:32 PDT 
Created attachment 304443 [details]
[Image] "Function" column should be aligned left for LTR layout

Regressed when we started using `text-align: start` on <th> https://trac.webkit.org/changeset/213622#file1

DataGrid headers should be aligned left for LTR layout and aligned right for RTL layout.

`text-align: start` would handle this if only WebKit didn't have a bug 141417.
`text-align: start` doesn't work for <th>.
Comment 1 Radar WebKit Bug Importer 2017-03-14 16:52:50 PDT 
<rdar://problem/31051520>
Comment 2 Nikita Vasilyev 2017-03-15 12:13:35 PDT 
Created attachment 304525 [details]
Patch
Comment 3 WebKit Commit Bot 2017-03-15 12:35:06 PDT 
Comment on attachment 304525 [details]
Patch

Clearing flags on attachment: 304525

Committed r214002: <http://trac.webkit.org/changeset/214002>
Comment 4 WebKit Commit Bot 2017-03-15 12:35:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 zalan 2017-04-14 20:56:29 PDT 
bug 141417 is fixed now.
Comment 6 Nikita Vasilyev 2017-04-14 23:55:06 PDT 
(In reply to zalan from comment #5)
> bug 141417 is fixed now.

I saw it! Already posted a patch in Bug 170871 - Web Inspector: Use `text-align: start` for DataGrid headers.