Bug 141409 - a few more WEBCORE_EXPORT macros
Summary: a few more WEBCORE_EXPORT macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks: 136172
  Show dependency tree / graph
 
Reported: 2015-02-09 15:42 PST by Alex Christensen
Modified: 2015-02-09 17:21 PST (History)
1 user (show)

See Also:

Attachments
Patch (40.79 KB, patch)
2015-02-09 15:46 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (53.49 KB, patch)
2015-02-09 16:35 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-02-09 15:42:17 PST 
WEBCORE_EXPORT macros need updating to reflect the changes of the last 5 months.
Comment 1 Alex Christensen 2015-02-09 15:46:22 PST 
Created attachment 246300 [details]
Patch
Comment 2 Tim Horton 2015-02-09 15:51:07 PST 
Comment on attachment 246300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246300&action=review

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:71
> -        static WEBKIT_EXPORTDATA const JSC::ClassInfo s_info;
> +        WEBCORE_EXPORT static const JSC::ClassInfo s_info;

Are these changes right?

> Source/WebCore/bindings/objc/DOMInternal.h:53
> +WEBCORE_EXPORT @interface DOMNodeFilter : DOMObject <DOMNodeFilter>

‽ ‽ how

> Source/WebCore/page/DatabaseProvider.h:36
> +class WEBCORE_EXPORT DatabaseProvider : public RefCounted<DatabaseProvider> {

What does it mean to export a class? Also, is this the right placement for this?
Comment 3 Alex Christensen 2015-02-09 16:01:38 PST 
(In reply to comment #2)
> Comment on attachment 246300 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246300&action=review
> 
> > Source/WebCore/bindings/js/JSDOMGlobalObject.h:71
> > -        static WEBKIT_EXPORTDATA const JSC::ClassInfo s_info;
> > +        WEBCORE_EXPORT static const JSC::ClassInfo s_info;
> 
> Are these changes right?
Yes.  When I make the switch, I'm going to get rid of WEBKIT_EXPORTDATA in favor of WEBCORE_EXPORT, which does the same thing.
> 
> > Source/WebCore/bindings/objc/DOMInternal.h:53
> > +WEBCORE_EXPORT @interface DOMNodeFilter : DOMObject <DOMNodeFilter>
> 
> ‽ ‽ how
I'm not sure, but this fixes linker errors of missing symbols like _OBJC_CLASS_$_DOMNodeFilter and _OBJC_METACLASS_$_DOMNodeFilter.
> 
> > Source/WebCore/page/DatabaseProvider.h:36
> > +class WEBCORE_EXPORT DatabaseProvider : public RefCounted<DatabaseProvider> {
> 
> What does it mean to export a class? Also, is this the right placement for
> this?
This is the right placement.  It exports the vtable.
Comment 4 Alex Christensen 2015-02-09 16:35:54 PST 
Created attachment 246303 [details]
Patch
Comment 5 Alex Christensen 2015-02-09 16:36:23 PST 
I added changes to the bindings tests.
Comment 6 WebKit Commit Bot 2015-02-09 17:21:43 PST 
Comment on attachment 246303 [details]
Patch

Clearing flags on attachment: 246303

Committed r179861: <http://trac.webkit.org/changeset/179861>
Comment 7 WebKit Commit Bot 2015-02-09 17:21:46 PST 
All reviewed patches have been landed.  Closing bug.