TestWebKitAccessibility should be skipped due to bug #132134, but it's not being skipped due to a thinko.
Created attachment 245908 [details] Patch
This probably means the test is not so flaky, I prefer not to skip tests that are working.
It fails very often, or I would not propose to skip it, see bug #132134
(In reply to comment #3) > It fails very often, or I would not propose to skip it, see bug #132134 how often? where did you get that information from? I don't see the test failing in the bots: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29
(In reply to comment #4) > how often? I've seen it work sometimes, but it almost always fails when I run it unless it is the only test being run (and even then it sometimes works, so "flaky"). There's also bug #140413. > where did you get that information from? I don't see the test > failing in the bots: > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29 I don't know why it works on the bots. At least we should remove the broken skip, if nothing else.
Specifically, https://bugs.webkit.org/show_bug.cgi?id=132134#c12
Skipped tests are for the bots, if this depends on the environment and it works in the bots, I would just remove the incorrect skip, and let the test run in the bots. Skipped tests are a source of unnoticed regressions.
Created attachment 245938 [details] Patch
Comment on attachment 245938 [details] Patch Clearing flags on attachment: 245938 Committed r179554: <http://trac.webkit.org/changeset/179554>
All reviewed patches have been landed. Closing bug.